Local GameplayCues using AvatarActor to emulate properly the behavior of a normal GameplayCue#118
Open
linqen wants to merge 1 commit into
Open
Local GameplayCues using AvatarActor to emulate properly the behavior of a normal GameplayCue#118linqen wants to merge 1 commit into
linqen wants to merge 1 commit into
Conversation
… of a normal GameplayCue The current behavior of the example GameplayCueLocal functions is not working as it would do with a normal GameplayCue. If we use GetOwner, the gameplay cue will always be executed sending the owner as "MyTarget", inside the GameplayCue. In case our ASC lives on the PlayerState, and our Character is the Avatar, this will result on inconsistent behavior between executing the GC using this new function, and the normal Execute/Add GameplayCue GetAvatarActor() instead of GetOwner() fixes this issue. Check UAbilitySystemComponent::InvokeGameplayCueEvent to confirm that this is the default/expected behavior.
linqen
marked this pull request as ready for review
August 29, 2023 17:23
Author
|
@tranek is it possible to take a look at this? I think just looking at the code makes completely sense. GetAvatarActor will return the same as GetOwner when the Owner is AvatarActor, but will also return the proper actor when Avatar != Owner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior of the example GameplayCueLocal functions is not working as it would do with a normal GameplayCue.
If we use GetOwner, the gameplay cue will always be executed sending the owner as "MyTarget", inside the GameplayCue.
In case our ASC lives on the PlayerState, and our Character is the Avatar, this will result on inconsistent behavior between executing the GC using this new function, and the normal Execute/Add GameplayCue
GetAvatarActor() instead of GetOwner() fixes this issue.
Check UAbilitySystemComponent::InvokeGameplayCueEvent to confirm that this is the default/expected behavior.