Skip to content

fix: idOnlySchema made nullable - #656

Merged
michaldrabik merged 1 commit into
masterfrom
fix/nullable-comment-params
Dec 3, 2025
Merged

michaldrabik merged 1 commit into
masterfrom
fix/nullable-comment-params

Conversation

@michaldrabik

Copy link
Copy Markdown
Collaborator

This PR makes post comment request object media params nullish. Results in properly generated Request:

@Serializable
data class PostCommentsPostRequest (

    @SerialName(value = "comment")
    val comment: kotlin.String,

    @SerialName(value = "spoiler")
    val spoiler: kotlin.Boolean,

    @SerialName(value = "movie")
    val movie: PostCommentsPostRequestAllOfOneOfMovie? = null,

    @SerialName(value = "show")
    val show: PostCommentsPostRequestAllOfOneOfMovie? = null,

    @SerialName(value = "season")
    val season: PostCommentsPostRequestAllOfOneOfMovie? = null,

    @SerialName(value = "episode")
    val episode: PostCommentsPostRequestAllOfOneOfMovie? = null,

    @SerialName(value = "list")
    val list: PostCommentsPostRequestAllOfOneOfMovie? = null
)

@seferturan

Copy link
Copy Markdown
Contributor

@michaldrabik, when posting a comment, isn't the ID always known?

@michaldrabik

Copy link
Copy Markdown
Collaborator Author

@michaldrabik, when posting a comment, isn't the ID always known?

This is about one level "higher" if you post a comment with a body for movie I can't be forced to provide shows/season/episode/list params.

@michaldrabik
michaldrabik merged commit 70d3886 into master Dec 3, 2025
3 checks passed
@michaldrabik
michaldrabik deleted the fix/nullable-comment-params branch December 3, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants