Skip to content

fix: remove extra ? in /watchnow query - #653

Merged
seferturan merged 1 commit into
masterfrom
fix/country-query
Dec 1, 2025
Merged

seferturan merged 1 commit into
masterfrom
fix/country-query

Conversation

@michaldrabik

Copy link
Copy Markdown
Collaborator

Removes extra ? that caused generating query as:

https://apiz.trakt.tv/shows/144629/watchnow/us??links=direct

which caused missing link_direct in responses.

@seferturan seferturan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this makes country mandatory and breaks getting all countries:

Image

When I test it with direct links, it doesn't get added:

Image Image

Maybe an issue with the openapi generation 🤔

@michaldrabik

Copy link
Copy Markdown
Collaborator Author

@seferturan Will Slack you later to figure it out then

@seferturan

Copy link
Copy Markdown
Contributor

I'll also have a look, seems the generated one is still sees it as required & adds the ? there 😅
Screenshot 2025-12-01 at 08 09 50

@vladjerca

Copy link
Copy Markdown
Contributor

Hmm, this makes country mandatory and breaks getting all countries:

Image

When I test it with direct links, it doesn't get added:

Image Image

Maybe an issue with the openapi generation 🤔

That is strange 🤔

@seferturan

Copy link
Copy Markdown
Contributor

Fixed by making it optional in the param schema instead of relying on ?.

@seferturan
seferturan self-requested a review December 1, 2025 10:05
@seferturan
seferturan merged commit fd0a764 into master Dec 1, 2025
3 checks passed
@seferturan
seferturan deleted the fix/country-query branch December 1, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants