Skip to content

fix(api): openapi string dates and nullish user stats - #1062

Merged
StefanFriptu merged 2 commits into
masterfrom
fix/action-date-openapi-string
Nov 9, 2026
Merged

StefanFriptu merged 2 commits into
masterfrom
fix/action-date-openapi-string

Conversation

@michaldrabik

Copy link
Copy Markdown
Collaborator
  • watched_at / collected_at: the datetime-or-keyword union generated an
    ambiguous oneOf (keywords matched both branches) and empty codegen models.
    Now one refined string schema (actionDateSchema). Spec emits
    type: string. Runtime validation is unchanged.
  • User stats: progress, lists, total_minutes and total_plays are
    now nullish, since the response can omit them.

Tested: bun run test, bun run check, build:types, openapi:validate.

The datetime-or-keyword union generated an ambiguous oneOf: keyword
values matched both branches, and codegen produced empty models.
Use a single refined string schema instead; runtime validation is kept.
The stats response can omit these fields, but the schema marked them
required, so generated clients failed to decode such responses.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T17:21:05.090508Z b5680a1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@StefanFriptu
StefanFriptu merged commit e7bc6c1 into master Nov 9, 2026
9 checks passed
@StefanFriptu
StefanFriptu deleted the fix/action-date-openapi-string branch November 9, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants