Repository navigation
feat(developer): request Production access from the app page - #1061
Conversation
14310dd to
879d882
Compare
🎶 Changes since opening 🎶
|
879d882 to
86e9c8f
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
86e9c8f to
188136a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86e9c8f7b1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
5fa9e6a to
be7721f
Compare
Adds a Production access panel to each app: developers send their app information for review, follow its status, resubmit, update their information later and ask for a server-to-server Client Secret, which is always reviewed. A grant creates a separate Production app; read-only Production apps are supported. Development apps accept any redirect; Production apps need public https redirects. The form shows each error under its field.
be7721f to
9bc2a00
Compare
seferturan
left a comment
There was a problem hiding this comment.
Folded in:
- redirect check only treats real IPv4 addresses as private, so
10.example.comis allowed (matches the API) - panel keeps the review from the POST response, so a failed list refresh no longer shows the request button again
- commit body rewrapped for commitlint
Developers can now ask for Production access from their app page, instead of contacting us. Granting a request means the app may use a Production Client ID. It is not an endorsement of the app.
Ships after the matching API changes are deployed. Until then, the new panel shows a load error.
App page
Redirects
com.example.app:/oauth. Script schemes (javascript:,data:,vbscript:,blob:) are refused on every app, as the API does.Form
Docs
Testing
listAccounts.spec.ts; they fail on master too.