Skip to content

feat(developer): request Production access from the app page - #1061

Merged
seferturan merged 2 commits into
masterfrom
feat/developer-production-requests
Nov 9, 2026
Merged

seferturan merged 2 commits into
masterfrom
feat/developer-production-requests

Conversation

@kevincador

Copy link
Copy Markdown
Contributor

Developers can now ask for Production access from their app page, instead of contacting us. Granting a request means the app may use a Production Client ID. It is not an endorsement of the app.

Ships after the matching API changes are deployed. Until then, the new panel shows a load error.

App page

  • New Production access section (named App information once a Production app exists).
  • Development apps cover the owner plus up to 16 invited people, and accept any redirect URI except script schemes.
  • Requesting access sends the app information: description (100 to 500 characters), open source, links, privacy policy, Trakt notice proof, expected monthly users, how the app uses Trakt, and other data or sync services.
  • Standard developers wait for a review. Premium developers get the Production app right away.
  • A grant creates a separate Production app with its own Client ID. The Development app stays as the sandbox.
  • Read-only Production access for apps that only read public data: nobody can sign in to them.
  • Status banner for pending, changes requested, declined and granted, with "Edit and resubmit" or "Request another review".
  • After a grant, developers can update their app information or request a server-to-server Client Secret. Both go through a review.

Redirects

  • Development apps accept any redirect, including native callbacks like com.example.app:/oauth. Script schemes (javascript:, data:, vbscript:, blob:) are refused on every app, as the API does.
  • Production apps need public https redirects. This is checked on create and when the redirect list changes; existing redirects keep working.
  • Read-only Production apps hide the redirect field and save without one. Full Production apps with no redirects (device code) can keep the list empty.
  • The request form checks redirects before sending: no whitespace, query or fragment, and 1 to 25 within 2,048 characters. It asks for redirects whenever the Production app has none, so a device-code app can move to PKCE.
  • The same private hosts as the API are refused, including trailing-dot hosts and IPv4 inside IPv6.
  • App information limits match the stored columns: links up to 2,048 characters with no spaces, privacy link up to 500, expected users up to 4,294,967,295.
  • A full Production app can't switch to public data only, and a read-only grant on a full app no longer reads as "nobody can sign in".
  • New messages for "another request was just sent" and "this app already supports sign-in".

Form

  • Errors show under each field after the first submit, update while typing, and focus jumps to the first one.
  • The description counter counts down to the 100-character minimum.
  • Hints are read as field descriptions by screen readers.

Docs

  • The create-an-app guide gains a "Going to production" section.

Testing

  • Check, lint, format (Biome and Prettier) and build pass.
  • Tests: 468 pass. 4 fail in listAccounts.spec.ts; they fail on master too.
  • Validated earlier against a local stub of the same API. The stub is not part of this PR.

@seferturan
seferturan force-pushed the feat/developer-production-requests branch 2 times, most recently from 14310dd to 879d882 Compare November 9, 2026 10:15
@seferturan

Copy link
Copy Markdown
Contributor

🎶 Changes since opening 🎶

  • Premium: a Client Secret request now waits for a review, copy + guide updated
  • Clear error when deleting a Development app that has a Production app
  • FormField component, better focus and status announcements
  • Small fixes + tests from review

@seferturan
seferturan force-pushed the feat/developer-production-requests branch from 879d882 to 86e9c8f Compare November 9, 2026 12:12
@seferturan
seferturan marked this pull request as ready for review November 9, 2026 12:13
@seferturan
seferturan self-requested a review November 9, 2026 12:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T12:16:27.283028Z 86e9c8f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@seferturan
seferturan force-pushed the feat/developer-production-requests branch from 86e9c8f to 188136a Compare November 9, 2026 12:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86e9c8f7b1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@seferturan
seferturan force-pushed the feat/developer-production-requests branch 2 times, most recently from 5fa9e6a to be7721f Compare November 9, 2026 12:27
Adds a Production access panel to each app: developers send their app
information for review, follow its status, resubmit, update their
information later and ask for a server-to-server Client Secret, which is
always reviewed. A grant creates a separate Production app; read-only
Production apps are supported. Development apps accept any redirect;
Production apps need public https redirects. The form shows each error
under its field.
@seferturan
seferturan force-pushed the feat/developer-production-requests branch from be7721f to 9bc2a00 Compare November 9, 2026 12:28

@seferturan seferturan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folded in:

  • redirect check only treats real IPv4 addresses as private, so 10.example.com is allowed (matches the API)
  • panel keeps the review from the POST response, so a failed list refresh no longer shows the request button again
  • commit body rewrapped for commitlint

@seferturan
seferturan merged commit 99aaec8 into master Nov 9, 2026
9 checks passed
@seferturan
seferturan deleted the feat/developer-production-requests branch November 9, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants