chore(client): remove auto metadata-backfill hook; run backfill manually - #404
Merged
Merged
Conversation
Contributor
|
👋 Heads-up — Code review queue is at 44 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 05627ea. Configure here.
divyasinghds
force-pushed
the
chore/remove-metadata-backfill-hook
branch
from
July 27, 2026 07:38
05627ea to
2955eae
Compare
The post-upgrade Helm hook (#380) coupled a one-time, best-effort data migration to every chart upgrade, which repeatedly surfaced timing and --timeout edge cases. The backfill is a one-time-per-cluster operation, so run it manually as a standalone Job instead. The tracebloc-backfill runner (data-ingestors #393/#395) is unchanged and remains the mechanism. Removes: - templates/metadata-backfill-hook.yaml - tests/metadata_backfill_hook_test.yaml - metadataBackfill block in values.yaml + values.schema.json Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
divyasinghds
force-pushed
the
chore/remove-metadata-backfill-hook
branch
from
July 27, 2026 07:44
2955eae to
853ef89
Compare
saadqbal
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Removes the automatic metadata-backfill runner (the post-upgrade Helm hook added in #380). The backfill will be run manually as a one-off Job instead of firing on every chart upgrade.
Deleted:
client/templates/metadata-backfill-hook.yaml— the post-upgrade hook Jobclient/tests/metadata_backfill_hook_test.yaml— its helm-unittestmetadataBackfillblock inclient/values.yaml(+ comment header)metadataBackfillproperty inclient/values.schema.jsonWhy
The auto-hook coupled a one-time, best-effort data migration to the chart's upgrade lifecycle, which repeatedly surfaced timing/
--timeoutedge cases in review. Since the backfill is genuinely a one-time operation per cluster, running it manually is simpler and removes that coupling entirely. The runner itself (tracebloc-backfillentrypoint, data-ingestors #393/#395) is unchanged and stays the mechanism — we just invoke it on demand.Manual run (replaces the hook)
Run the ingestor image's entrypoint as a standalone Job in the client namespace:
Verified on dev (
tb-client-dev-templates/tracebloc-templates): ok=98, skipped_current=26, not_found=26, errors=0. The sweep is idempotent, so re-running is safe.Testing
helm lint clientpasses.helm templaterenders 0 backfill objects.values.yaml/values.schema.jsonvalidate.🤖 Generated with Claude Code
Note
Low Risk
Chart-only removal of an optional hook; no changes to ingestor runtime, jobs-manager, or auth paths. Upgrades no longer run backfill automatically—clusters that still need migration must run it manually once.
Overview
Removes the automatic federated-alignment metadata backfill from the client Helm chart. Chart upgrades no longer spawn a post-upgrade hook Job that ran
tracebloc-backfillon the ingestor image.Deleted:
metadata-backfill-hook.yaml, its helm-unittest suite, and themetadataBackfillvalues block (includingenabled,backfillTimeoutSeconds, and resources) fromvalues.yamlandvalues.schema.json.The
tracebloc.ingestorDigesthelper comment is updated so ingestor image resolution is documented for jobs-manager ingestion Jobs and manual backfill Jobs only—not the removed hook.Operators run the same
tracebloc-backfillentrypoint as a one-off Job when needed; the sweep stays idempotent.Reviewed by Cursor Bugbot for commit 853ef89. Bugbot is set up for automated code reviews on this repo. Configure here.