Skip to content

fix: Bugbot findings from promotion PR #383 - #390

Merged
shujaatTracebloc merged 2 commits into
developfrom
fix/bugbot-installer-copy
Jul 24, 2026
Merged

fix: Bugbot findings from promotion PR #383#390
shujaatTracebloc merged 2 commits into
developfrom
fix/bugbot-installer-copy

Conversation

@shujaatTracebloc

@shujaatTracebloc shujaatTracebloc commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Resolves Cursor Bugbot findings surfaced on the client promotion PR (#383, develop → main).

Fixes:

Lands on develop; the promotion PR head picks these up on the next sync and Bugbot re-reviews.

🤖 Generated with Claude Code


Note

Low Risk
User-facing wording and test-only harness changes; no install logic or privilege paths are altered.

Overview
Addresses Bugbot feedback on the installer copy catalog tests and host audit messaging.

Tier 1 honesty: The host-check panel no longer implies zero admin for Tier 1; it now states that Docker is set up for the user’s account but a one-time admin step is still required until rootless Docker ships (#1177). Golden copy and probe.bats expectations follow.

Golden catalog robustness: Step headers are scraped with [a-z] instead of [a-f] so future steps aren’t dropped silently. print_summary output for outcome goldens is captured via a single temp file (stdout and stderr merged) to avoid pipe interleaving flakes. Missing golden files get a clear TB_UPDATE_GOLDEN regenerate hint instead of a raw diff error.

scripts/manifest.sha256 is updated for probe.sh.

Reviewed by Cursor Bugbot for commit 1a3b5ad. Bugbot is set up for automated code reviews on this repo. Configure here.

- Golden step scrape: broaden [a-f] to [a-z] so new steps stay covered
- Golden summary capture: route stdout+stderr through a file for deterministic ordering
- check_golden: point at TB_UPDATE_GOLDEN=1 when the golden is missing
- Host audit: stop promising "no admin" for Tier 1 until rootless lands

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@shujaatTracebloc shujaatTracebloc self-assigned this Jul 24, 2026
The supply-chain manifest pins a SHA per sub-script; the Tier 1 host-audit
wording fix changed scripts/lib/probe.sh, so regenerate scripts/manifest.sha256.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@shujaatTracebloc
shujaatTracebloc merged commit 658bc30 into develop Jul 24, 2026
31 checks passed
@shujaatTracebloc
shujaatTracebloc deleted the fix/bugbot-installer-copy branch July 24, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants