fix: Bugbot findings from promotion PR #383 - #390
Merged
Conversation
- Golden step scrape: broaden [a-f] to [a-z] so new steps stay covered - Golden summary capture: route stdout+stderr through a file for deterministic ordering - check_golden: point at TB_UPDATE_GOLDEN=1 when the golden is missing - Host audit: stop promising "no admin" for Tier 1 until rootless lands Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The supply-chain manifest pins a SHA per sub-script; the Tier 1 host-audit wording fix changed scripts/lib/probe.sh, so regenerate scripts/manifest.sha256. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saadqbal
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Cursor Bugbot findings surfaced on the client promotion PR (#383, develop → main).
Fixes:
[a-f]to[a-z]so a future step isn't silently dropped from the catalog. (Release develop → main #383 (comment))print_summarythrough a temp file so stdout+stderr keep deterministic order across machines. (Release develop → main #383 (comment))check_goldennow points atTB_UPDATE_GOLDEN=1when a golden file is absent instead of a raw diff error. (Release develop → main #383 (comment))Lands on develop; the promotion PR head picks these up on the next sync and Bugbot re-reviews.
🤖 Generated with Claude Code
Note
Low Risk
User-facing wording and test-only harness changes; no install logic or privilege paths are altered.
Overview
Addresses Bugbot feedback on the installer copy catalog tests and host audit messaging.
Tier 1 honesty: The host-check panel no longer implies zero admin for Tier 1; it now states that Docker is set up for the user’s account but a one-time admin step is still required until rootless Docker ships (#1177). Golden copy and
probe.batsexpectations follow.Golden catalog robustness: Step headers are scraped with
[a-z]instead of[a-f]so future steps aren’t dropped silently.print_summaryoutput for outcome goldens is captured via a single temp file (stdout and stderr merged) to avoid pipe interleaving flakes. Missing golden files get a clear TB_UPDATE_GOLDEN regenerate hint instead of a rawdifferror.scripts/manifest.sha256is updated forprobe.sh.Reviewed by Cursor Bugbot for commit 1a3b5ad. Bugbot is set up for automated code reviews on this repo. Configure here.