Add scala native platform - #341
Open
ivan-klass wants to merge 2 commits into
Open
Conversation
Author
|
@tototoshi @xuwei-k could you please take a look? I believe the PR is merge-ready |
ivan-klass
force-pushed
the
native-platform
branch
from
March 10, 2026 18:28
c2b4f1c to
1297512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
src/main/javain Scala (assrc/main/scala-readers) and adds a ScalaNative platform. Later it would be much easier to add JS also.Currently, new sources are only connected to non-JVM builds, and there are no changes to the JVM platform at all.
JVM build uses exactly the same sources and compile settings as before, so maybe there's no need for a version bump, as there are no changes to ship compared to existing 2.0.0 artifacts.
As for the upcoming versions, it would be nice to drop
src/main/javacompletely. Unfortunately, these interfaces are defined as public. Following semver conventions strictly, that might be considered as requiring a major version bump, but it seems very unlikely that library users extend existing LineReaders to implement their own.If needed, I can separate this PR into parts, like:
build.sbtto multi-projects (first commit)please let me know if it would make sense.