fix: use subquery for DELETE with JOINs on SQLite/PostgreSQL#2151
Open
themavik wants to merge 1 commit intotortoise:developfrom
Open
fix: use subquery for DELETE with JOINs on SQLite/PostgreSQL#2151themavik wants to merge 1 commit intotortoise:developfrom
themavik wants to merge 1 commit intotortoise:developfrom
Conversation
…e#1981) Root cause: DELETE with LEFT JOIN is only valid in MySQL. When filtering through backward relations, resolve_filters adds JOINs that produce invalid SQL on SQLite and PostgreSQL. Made-with: Cursor
themavik
commented
Mar 19, 2026
Author
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Reviewed the changes — the implementation is clean and follows the existing patterns.
Member
|
What is relation of this PR to #2139 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE FROM table LEFT OUTER JOIN ...which is invalid SQL in SQLite and PostgreSQLRoot Cause
DeleteQuery._make_query()sets_delete_from = Trueon the query afterresolve_filters()adds JOINs for relation-based filters. The resulting SQL uses DELETE with JOIN, which only MySQL supports.Fix
After
resolve_filters(), check if_joined_tablesis non-empty. If JOINs are present, convert the query to use a subquery approach:This is valid SQL across all supported databases.
Testing
Fixes #1981
Fixes #1167
Made with Cursor