Define float/double math functions in generator#390
Open
szagoruyko wants to merge 1 commit intotorch:masterfrom
szagoruyko:generic_math
Open
Define float/double math functions in generator#390szagoruyko wants to merge 1 commit intotorch:masterfrom szagoruyko:generic_math
szagoruyko wants to merge 1 commit intotorch:masterfrom
szagoruyko:generic_math
Conversation
Member
|
@szagoruyko the definitions are in the wrong place. (see where the undef for floats are for example, they come right after the defines). can you re-check the PR. |
Member
Author
|
oops, I have to be more careful. fixed |
Contributor
|
Shouldn't you also modify THTensorMath.c to reflect those changes ? Like in https://github.com/torch/torch7/blob/master/lib/TH/generic/THTensorMath.c#L1843 ? More generally, change all calls to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that generated functions can use corresponding functions. Patch is coming from ztorch/lib/THZ/THZGenerateAllTypes.h
fix for nn functions is coming
cc @fmassa