-
Notifications
You must be signed in to change notification settings - Fork 0
파티셔닝시 CanonicalOperation 을 blob object 로 리턴하도록 수정 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
파티셔닝시 CanonicalOperation 을 blob object 로 리턴하도록 수정 #23
Conversation
Summary of ChangesHello @toothlessdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 풀 리퀘스트는 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Test Results110 tests 110 ✅ 2s ⏱️ Results for commit 35cf528. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 파티셔닝 로직을 리팩토링하여 CanonicalOperation을 해시 트리에서 분리하고 별도의 hashObjects로 반환하도록 수정한 점이 인상적입니다. 이는 향후 데이터와 해시 트리를 별도로 저장하려는 목표에 잘 부합하는 좋은 구조적 개선입니다. 파일 구조를 types와 utils로 정리한 것도 코드의 모듈성을 높이는 좋은 변경입니다.
리뷰에서는 주로 새로 추가된 테스트 코드의 중복을 줄이고, HashNode 타입의 안정성을 높이는 방안에 대한 몇 가지 제안을 포함했습니다. 전반적으로 훌륭한 변경이라고 생각합니다.
packages/patchlogr-core/src/partition/__tests__/partitionByMethod.test.ts
Show resolved
Hide resolved
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
📎 Related issues
📦 Scope
📌 Summary
🧠 Context
✅ Checklist