Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ impl Command {
let value = u16::from_be_bytes([msb, lsb]);
Ok(Some((Command::FanSpeed { target, value }, 4)))
},
[header, ..] if b"BCD".contains(&header) => Ok(None),
[header, ..] if b"BCDF".contains(&header) => Ok(None),
_ => Err(Error::MalformedMessage),
}
}
Expand Down Expand Up @@ -303,9 +303,19 @@ mod tests {
];

for command in commands.iter() {
let (deserialized, _len) =
Command::try_from(&command.as_arrayvec()[..]).unwrap().unwrap();
assert_eq!(command, &deserialized);
let serialized = command.as_arrayvec();

for len in 0..serialized.len() {
let res = Command::try_from(&serialized[0..len]).unwrap();

if len < serialized.len() {
// Must return None until we receive the full command.
assert!(res.is_none())
} else {
// After we receive the command in full, it successfully parses.
assert!(res.is_some_and(|(parsed_command, _)| parsed_command == *command));
}
}
}
}

Expand All @@ -314,9 +324,19 @@ mod tests {
let reports = [Report::Press, Report::Release, Report::DialValue { diff: 100 }];

for report in reports.iter() {
let (deserialized, _len) =
Report::try_from(&report.as_arrayvec()[..]).unwrap().unwrap();
assert_eq!(report, &deserialized);
let serialized = report.as_arrayvec();

for len in 0..serialized.len() {
let res = Report::try_from(&serialized[0..len]).unwrap();

if len < serialized.len() {
// Must return None until we receive the full report.
assert!(res.is_none())
} else {
// After we receive the Report in full, it successfully parses.
assert!(res.is_some_and(|(parsed_report, _)| parsed_report == *report));
}
}
}
}

Expand Down