Skip to content

feat: add architecture check for RPM build script#393

Open
eos175 wants to merge 1 commit into
tonarino:mainfrom
eos175:feature/rpm-arch-check
Open

feat: add architecture check for RPM build script#393
eos175 wants to merge 1 commit into
tonarino:mainfrom
eos175:feature/rpm-arch-check

Conversation

@eos175
Copy link
Copy Markdown
Contributor

@eos175 eos175 commented Apr 18, 2026

No description provided.

Copy link
Copy Markdown
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds sensible, though I have very little context about the RPM build scripts.

BTW where does limitation of not supporting cross compilation come from? From using docker build?

FWIW I'd be also very open to move the RPM build infrastructure to an external git repo, where someone more versed with RPM-based distros could maintain it. This seems to work well for Deb packages.

@strohel
Copy link
Copy Markdown
Member

strohel commented Apr 20, 2026

FWIW I'd be also very open to move the RPM build infrastructure to an external git repo, where someone more versed with RPM-based distros could maintain it. This seems to work well for Deb packages.

This is related to #203, I see @wwalker and @refi64 were active to an extent on RPM builds.

@eos175
Copy link
Copy Markdown
Contributor Author

eos175 commented Apr 22, 2026

Hi @strohel,

The main reason is that cross-compiling can be quite slow and often creates compatibility issues across different distributions. For me, managing all those variations is complicated and difficult to maintain.

I believe the most reliable approach for now is to simply build the package on the specific platform and architecture where it's needed. This check just ensures the script runs in the correct environment to avoid broken builds.

I'm not planning on making more complex changes, so this small validation helps keep things stable for anyone using the script as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants