Results viewer: close each render job's env - #163
Merged
Conversation
merlerm
changed the title
merlerm
force-pushed
the
viewer-env-teardown
branch
from
August 21, 2026 10:05
f84532b to
c70f3d5
Compare
A replay environment was left open once its job ended, so every render and history evaluation leaked its PyBullet DIRECT client and the meshes loaded into it for the lifetime of the server. Each job now owns its env and closes it in a finally, covering the success, cancel and error paths alike.
merlerm
force-pushed
the
viewer-env-teardown
branch
from
September 2, 2026 09:14
c70f3d5 to
e6fd986
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The render worker never closed its per-job env, so every job leaked a PyBullet DIRECT client plus its meshes; a 22-job render queue reached 13.9 GB RSS and was OOM-killed mid-batch. Envs are now closed in a
finallyin both the render worker and the full-history evaluation, covering success, cancellation, and error paths. Each job rebuilds its env from scratch; if back-to-back render latency ever matters, a bounded per-run cache would be the follow-up.