Fix the build problems in issue 22 related to FFI#24
Open
dan-at-confirm wants to merge 5 commits intotmthecoder:mainfrom
Open
Fix the build problems in issue 22 related to FFI#24dan-at-confirm wants to merge 5 commits intotmthecoder:mainfrom
dan-at-confirm wants to merge 5 commits intotmthecoder:mainfrom
Conversation
|
Didn't realize this branch was associated with a PR, sorry about that. FWIW I tried to make the arm64 runner work with android tests and kept running into this issue: actions/runner-images#9472 (comment) which is why there are so many commits. Tests are passing, I'll squash some stuff. |
|
Flutter tests pass after upgrading some of the CI toolchain, but the top level workflow is commented out at the moment. |
Author
|
@tmthecoder how does this look to you? |
|
I fixed the top level tests as well, but I used a deprecation override to do so. The correct solution (required for Dart 3.4) is to use isolates, I believe. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #22
This PR is being opened on behalf of @qui-jason.
It seems there was an upgrade to the ffi plugin that requires a minor change.