Conversation
felixlinker
reviewed
Sep 15, 2026
Co-authored-by: Felix Linker <linkerfelix@gmail.com>
tuexen
approved these changes
Sep 15, 2026
felixlinker
approved these changes
Sep 17, 2026
felixlinker
left a comment
felixlinker
left a comment
There was a problem hiding this comment.
Just some editorial feedback, and one hint on potentially more precise language!
I would also probably change some wording on the attacker model, but I think it's better to do this in a full pass over the document.
Comment on lines
+160
to
+161
| new traffic keys that compromise of prior traffic keys does not help | ||
| derive. As noted in |
There was a problem hiding this comment.
I think this sentence got a bit mangled up during editing.
Comment on lines
+861
to
+862
| is aligned with the updated security context. Compromise of a previous exporter secret does not help derive the newly | ||
| derived exporter secret. |
There was a problem hiding this comment.
I don't know much about exporter secrets, but there was other language where we changed "does not help to derive" to "does not suffice to derive." Just flagging that the "does not suffice to" wording might be more accurate here as well. I would only use "does not help" if the old exporter secret cannot be used in any way to compute the new exporter secret.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.