HermeticFetchContent v1.0.25 + v1.0.26 : Hermetic find_package() improvements + Auto-detect and expose package version in find_package() provider - #50
Open
pysco68 wants to merge 2 commits into
Conversation
pysco68
force-pushed
the
feature/TIPI-1757/transitive-dependency-handling
branch
2 times, most recently
from
June 2, 2026 15:09
ba42bec to
e7443e1
Compare
pysco68
force-pushed
the
feature/TIPI-1757/toolchain-fingerprinting
branch
4 times, most recently
from
June 8, 2026 09:31
6081878 to
cdef43d
Compare
Orphis
requested changes
Jun 8, 2026
Orphis
left a comment
Orphis
left a comment
Contributor
There was a problem hiding this comment.
It might be worth it adding to the release notes that this is a caching key change and that everything will need to be rebuilt against the new computed cache key.
Also, did you measure how long it takes to generate this subproject for each dependency in a large project?
pysco68
force-pushed
the
feature/TIPI-1757/transitive-dependency-handling
branch
2 times, most recently
from
June 8, 2026 13:35
1e3777d to
87fdc8e
Compare
pysco68
force-pushed
the
feature/TIPI-1757/toolchain-fingerprinting
branch
from
June 8, 2026 14:52
cdef43d to
5389022
Compare
pysco68
force-pushed
the
feature/TIPI-1757/transitive-dependency-handling
branch
from
June 8, 2026 14:56
87fdc8e to
dd2c17c
Compare
pysco68
marked this pull request as ready for review
June 8, 2026 15:29
pysco68
force-pushed
the
feature/TIPI-1757/toolchain-fingerprinting
branch
3 times, most recently
from
June 10, 2026 10:20
4c26efe to
050c8c6
Compare
pysco68
force-pushed
the
feature/TIPI-1757/transitive-dependency-handling
branch
from
June 11, 2026 08:48
dd2c17c to
0441fb5
Compare
pysco68
changed the base branch from
feature/TIPI-1757/toolchain-fingerprinting
to
main
June 11, 2026 08:59
Orphis
requested changes
Jun 11, 2026
Orphis
approved these changes
Jun 12, 2026
Orphis
left a comment
Orphis
left a comment
Contributor
There was a problem hiding this comment.
LGTM, satisfied by all the changes!
CHANGELOG:
- HERMETIC_DEFER_NATIVE_ROOTED_FIND_PACKAGE_FOR: forward find_package() calls to cmake's
native implementation rooted at the HFC install prefix instead of serving from the target cache
- HERMETIC_<content-name>_FIND_PACKAGE_EXTRA_CODE: inject arbitrary cmake code into the
provider when find_package() is handled for a dependency (e.g. to set <Pkg>_VERSION)
- Proxy toolchains embed dependency state fingerprints for transitive invalidation when an
upstream dependency changes
- HERMETIC_<content-name>_FIND_PACKAGE_EXTRA_CODE: inject arbitrary cmake code into the
provider when find_package() is handled for a dependency (e.g. to set <Pkg>_VERSION)
- Proxy toolchains embed dependency fingerprints for transitive invalidation when an upstream
dependency changes
- Transient content aliases now resolve correctly through find_package() in sub-builds
- Alias deduplication: multiple aliases resolving to the same canonical content produce a
single registration in the proxy toolchain (e.g. HERMETIC_FIND_PACKAGES "jemalloc;jemallocAlt")
Change-Id: I3a656d3f93f1e4ae8abcfa877f65db238aa2a59a
pysco68
force-pushed
the
feature/TIPI-1757/transitive-dependency-handling
branch
from
June 12, 2026 12:43
5701b10 to
85e1fb4
Compare
… in find_package() provider CHANGELOG - Auto-detect package version from ConfigVersion.cmake and pkg-config .pc files - Add HERMETIC_FIND_PACKAGE_VERSION_OVERRIDE parameter to FetchContent_MakeHermetic() (takes priority over auto-detection) - HERMETIC_<pkg>_FIND_PACKAGE_EXTRA_CODE takes highest precedence and can override any version Co-Authored-By: Claude Opus 4.6 Change-Id: Ibdc6b2f59819050b43137911fd42a9910ed85bd9
daminetreg
requested changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
This is great but need communication with users before this can be merged.
See https://github.com/tipi-build/specs-cmake-re/issues/463#issuecomment-4727862969
daminetreg
changed the title
daminetreg
requested changes
Jun 25, 2026
Contributor
There was a problem hiding this comment.
Commit id repeats the same CHANGELOG line items multiple time
- Organizational reasons not to merge now https://github.com/tipi-build/specs-cmake-re/issues/463#issuecomment-4798211087
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
native implementation rooted at the HFC install prefix instead of serving from the target cache
provider when find_package() is handled for a dependency (e.g. to set _VERSION)
upstream dependency changes
provider when find_package() is handled for a dependency (e.g. to set _VERSION)
dependency changes
single registration in the proxy toolchain (e.g. HERMETIC_FIND_PACKAGES "jemalloc;jemallocAlt")
Change-Id: I3a656d3f93f1e4ae8abcfa877f65db238aa2a59a
In context of:
https://github.com/tipi-build/specs-cmake-re/issues/447