Repository navigation
fix(render): let the native tool protocol allow a lead-in line before tool calls - #15
Conversation
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["one"]:::impacted
n1["ok"]:::impacted
n2["response"]:::impacted
n3["...e_dialect_carries_the_flag_onto_the_entry"]:::impacted
n4["...ect_values_fallback_and_protocol_metadata"]:::impacted
n3 -->|calls| n0
n3 -->|tests| n0
n3 -->|calls| n1
n3 -->|tests| n1
n4 -->|calls| n0
n4 -->|tests| n0
n4 -->|calls| n1
n4 -->|tests| n1
n4 -->|calls| n2
n4 -->|tests| n2
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe native tool-use instructions now allow a brief announcement when the tool call occurs in the same message. The test verifies the new wording and the removal of the previous prohibitive wording. ChangesNative tool-use guidance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change permits brief same-message lead-ins for native tool calls while preserving the requirement to call the tool and continue to a final answer. It is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
A rabbit reads the call, Comment |
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0050 · 104,143 in / 3,107 out · 23,787 cached (23%) · flash, ladder/vectors, gpt-5.6-luna, deepseek/deepseek-v4-flash · 221 embedded
critique: $0.0023 · 46,146 in / 767 out · 3,315 cached (7%) · gpt-5.6-luna
security: $0.0015 · 29,591 in / 252 out · 0 cached (0%) · gpt-5.6-luna
tests: $0.0004 · 15,640 in / 99 out · 11,674 cached (75%) · deepseek/deepseek-v4-flash
description: $0.0002 · 6,968 in / 84 out · 3,000 cached (43%) · deepseek/deepseek-v4-flash
Summary
native_instructions()told models: "Do not only narrate intent (for example, avoid "Let me check...") without emitting the tool call." The intent was "don't announce without acting", but the example read as a ban on any lead-in text, and hosts that also ban preamble in their own style rules (OpenHuman) ended up with models that emit tool calls and nothing else for the first 20–40 s of a turn.Hermes gets a visible "Let me look that up…" in the same message as its
web_searchcall at ~5 s on the same model; the difference is only that it does not forbid the line.New wording:
The
native tool-callingphrase the dialect test pins is preserved; a regression test asserts the lead-in is allowed and the old "Let me check" example is gone.Testing
cargo test -p tinytools-agent(228 passed)cargo fmt --checkPart of the OpenHuman orchestrator latency work (tinyhumansai/openhuman, branch
hermes-prompt-diet).Co-authored-by: Medulla medulla@tinyhumans.ai
Summary by CodeRabbit