Skip to content

feat: expose linked TinyBus module entry point - #24

Merged
senamakel merged 6 commits into
tinyhumansai:mainfrom
senamakel:windows-linked-modules
Sep 29, 2026
Merged

senamakel merged 6 commits into
tinyhumansai:mainfrom
senamakel:windows-linked-modules

Conversation

@senamakel

@senamakel senamakel commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add opt-in tinymcp/static-link using TinyBus module_export_optional_static!, which selects dynamic exports by default and a Rust-addressable module in static builds.
  • Expose tinymcp::linked_module() for direct host registration.
  • Pin TinyBus commit 433d9ed and use =0.1.2 registry dependency identities, with local Cargo patches for standalone builds.

Related issue

Depends on tinyhumansai/tinybus#29, which builds on merged #28. Ready condition: #29 is merged, this gitlink is reachable from upstream TinyBus, and CI passes. This PR remains a draft until then.

API or behavior changes

Additive public linked_module() under static-link. The default loadable module path and wire contract are unchanged.

Validation

  • cargo fmt --manifest-path Cargo.toml --all -- --check
  • cargo check --manifest-path Cargo.toml -p tinymcp --offline
  • cargo check --manifest-path Cargo.toml -p tinymcp --features static-link --offline
  • Full clippy, build, test, and coverage suites have not been rerun on this final commit.

Tests

The two feature builds verify both TinyBus macro expansions and the public root reexport. No runtime behavior changes were added in this package.

Documentation

The feature and root entry point are documented in this PR and by TinyBus #29.

Checklist

  • The change is focused on static module registration.
  • No lint levels were relaxed in this update.
  • No secrets or environment contents are included.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 15 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: dc405aa7-aff7-4c83-acc4-1c4d8687d392

📥 Commits

Reviewing files that changed from the base of the PR and between de31dbb and 3b9d3e8.

📒 Files selected for processing (1)
  • Cargo.toml

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel marked this pull request as ready for review September 29, 2026 08:30
@tinysweeper

tinysweeper Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Incomplete
Priority: none
Reviewed head: 3b9d3e8116cf
Updated: 1790672488 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 3

Completeness: Incomplete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Could not review: Cargo.toml, tinysweeper/description

Before merge

  • Complete the critique review for Cargo.toml.
  • Complete the security review for Cargo.toml.
  • Complete the description review for tinysweeper/description.
Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: Cargo.toml
  • Lane summary: Reviewed 0 files; 0 findings. 1 file could not be reviewed: Cargo.toml.

security

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: Cargo.toml
  • Lane summary: Reviewed 0 files; 0 findings. 1 file could not be reviewed: Cargo.toml.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: tinysweeper/description
  • Lane summary: No reviewer could be consulted.

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.
Evidence and run details
  • Models: ladder/vectors, deepseek/deepseek-v4-flash
  • Spend: $0.000164
  • Tokens: 1652 input · 95 output · 0 cached · 66 embedding
Head State Pass summary
c7990e6a1f25 incomplete 0 active finding(s), 0 resolved finding(s) (at 1790670710)
3b9d3e8116cf incomplete 0 active finding(s), 0 resolved finding(s) (at 1790672488)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: Cargo.toml, crates/tinymcp/Cargo.toml, crates/tinymcp/src/lib.rs, crates/tinymcp/src/tinybus_module/mod.rs.

             $0.0025 · 25,961 in / 961 out · 0 cached (0%) · ladder/vectors, deepseek/deepseek-v4-flash · 184 embedded
tests:       $0.0015 · 16,210 in / 108 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0007 · 7,455 in  / 98 out  · 0 cached (0%) · deepseek/deepseek-v4-flash

@senamakel senamakel self-assigned this Sep 29, 2026
# Conflicts:
#	crates/tinymcp/Cargo.toml
#	crates/tinymcp/src/lib.rs
#	crates/tinymcp/src/tinybus_module/mod.rs
#	vendor/tinybus

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: Cargo.toml, tinysweeper/description.

$0.0002 · 1,652 in / 95 out · 0 cached (0%) · 66 embedded · ladder/vectors, deepseek/deepseek-v4-flash

@senamakel
senamakel merged commit 0fedb79 into tinyhumansai:main Sep 29, 2026
12 checks passed
sanil-23 pushed a commit to sanil-23/tinymcp that referenced this pull request Oct 5, 2026
…nto mcp-nested-args-normalize

Co-authored-by: Medulla <medulla@tinyhumans.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant