Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ updates:
directory: /
schedule:
interval: weekly
ignore:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

priority high critique likely

Do not ignore security patch updates

The wildcard ignore applies to every GitHub Action's semver-patch update, including patch releases that contain security fixes. Dependabot uses the ignore configuration when determining security update pull requests, so a vulnerable action whose fix is a patch release can be left without an automatic PR. Narrow the ignore rules to specific non-security dependencies or use a configuration that preserves security updates.


Additional critique observation

priority high likely

Do not ignore security patch updates

[RULE] security-update-suppression

The wildcard ignore applies to every dependency's semver-patch update, including patch releases that contain security fixes. Dependabot uses the ignore configuration when determining security update pull requests, so a vulnerable dependency whose fix is a patch release can be left without an automatic PR. Narrow the ignore rules to specific non-security dependencies or use a configuration that preserves security updates.


Additional security observation

priority medium confident

Do not suppress all patch dependency updates

[RULE] dependency-update-suppression

Ignoring every semver-patch update prevents Dependabot from proposing routine patch fixes for every dependency in this ecosystem. This can leave known bug fixes and non-security hardening unapplied indefinitely, especially when the next minor release is not imminent. Remove this blanket ignore or scope it to explicitly justified dependencies; apply the same correction to the second dependency group as well.

[RULE] security-update-suppression ·

- dependency-name: "*"
update-types: ["version-update:semver-patch"]
Comment on lines +8 to +9

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep security patch updates eligible

When a Cargo crate or GitHub Action vulnerability is fixed by a semver patch, this wildcard rule—and the identical rule at lines 24–26—filters out that security update, so Dependabot will not open the security PR; security updates are therefore not “unaffected” as the commit message states. GitHub lists ignore as a configuration option that also affects security-update pull requests. Avoid applying this blanket ignore to the default-branch configuration if security patch PRs must remain enabled.

Useful? React with 👍 / 👎.

open-pull-requests-limit: 5
commit-message:
prefix: "deps"
Expand All @@ -18,6 +21,9 @@ updates:
directory: /
schedule:
interval: weekly
ignore:
- dependency-name: "*"
update-types: ["version-update:semver-patch"]
open-pull-requests-limit: 5
commit-message:
prefix: "ci"
Expand Down
Loading