Skip to content

feat(harness): enforce tool timeout policies - #70

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:feat/tool-timeout-policy-runtime
Jul 23, 2026
Merged

senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:feat/tool-timeout-policy-runtime

Conversation

@senamakel

Copy link
Copy Markdown
Member

Summary

  • add shared, atomically updateable ToolTimeoutSettings with inherited, explicit, unbounded, clamp, and grace semantics
  • let RunPolicy opt into those settings without changing default behavior
  • enforce the tighter of the tool deadline and remaining run wall-clock budget in serial and parallel tool execution

This closes the gap where Tool::timeout_policy existed as metadata but the harness loop did not consume it.

Validation

  • cargo test timeout
  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features -- -D warnings

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e8534cb3-6c19-41f5-9a50-1a856a2280a1

📥 Commits

Reviewing files that changed from the base of the PR and between 2583fcc and bf07893.

📒 Files selected for processing (11)
  • README.md
  • docs/modules/harness/README.md
  • docs/spec/README.md
  • src/harness/agent_loop/model_call.rs
  • src/harness/agent_loop/test.rs
  • src/harness/agent_loop/tools.rs
  • src/harness/runtime/mod.rs
  • src/harness/runtime/types.rs
  • src/harness/tool/mod.rs
  • src/harness/tool/timeout.rs
  • src/harness/tool/timeout_test.rs

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5be107962

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/harness/runtime/types.rs Outdated
@senamakel
senamakel force-pushed the feat/tool-timeout-policy-runtime branch from d5be107 to 2e51250 Compare July 22, 2026 14:38

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e512501f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/harness/agent_loop/tools.rs Outdated
@senamakel
senamakel force-pushed the feat/tool-timeout-policy-runtime branch from 2e51250 to 02574a8 Compare July 22, 2026 14:52

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02574a8e21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/harness/agent_loop/tools.rs Outdated
@senamakel
senamakel force-pushed the feat/tool-timeout-policy-runtime branch from 02574a8 to 6c59a97 Compare July 22, 2026 15:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c59a97803

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/harness/runtime/mod.rs
@senamakel
senamakel force-pushed the feat/tool-timeout-policy-runtime branch from 6c59a97 to bf07893 Compare July 22, 2026 15:11
@senamakel
senamakel merged commit abbe97d into tinyhumansai:main Jul 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant