Repository navigation
feat(runtime): admit explicitly bounded nested subagent spawns - #518
Conversation
…agents-runtime/src/tool_registr Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
…tests.rs Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
The README now explains that sub-agent turns are leaf turns by default and that hosts must opt in via ToolAdmission::nested_spawn_depth, noting the runtime's allowlist and depth-ceiling checks and the host's remaining responsibility. The re-export list and a test assertion were reformatted without behaviour changes. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewReviewed head: Verdict: Ready for maintainer review · Priority: none Diagnostics and supporting detailsFull summaryPull request purpose (title): feat(runtime): admit explicitly bounded nested subagent spawns. The pull request adds an opt-in bounded nested-spawn admission path to the runtime so a host can let a sub-agent turn keep a spawn tool only when the ordinary allowlist admits it and one more child fits under a validated depth ceiling, while default sub-agent turns remain leaf-only. Review snapshot
Completeness: Complete What changedWhole pull request: it introduces `NestedSpawnDepth` with `try_new` ceiling validation and overflow-safe `allows_child`, adds `ToolAdmission::nested_spawn_depth` defaulting to `None`, and updates `plan_registration` so a sub-agent spawn tool is refused unless the ordinary allowlist check passes and the depth grant admits another child. The type is re-exported from the crate and the module README documents that the host must enforce the same ceiling when it executes the spawn. Latest-push-delta: unavailable because there is no trusted base-to-head diff comparison between the prior reviewed head and the current head; cached prompt differences are not treated as a proven push delta. Features
Tests
FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab31383505
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Update the module and field documentation to describe that spawn and delegate tools are withheld from sub-agent runs by default rather than never handed out, and that a host may grant bounded nested spawning for a turn. The new wording also notes that granted tools must still pass the ordinary allowlist and that the host enforces the depth ceiling when a child executes. Auto-committed-on: cuttlefish Co-authored-by: Medulla <medulla@tinyhumans.ai>
7814825
into
tinyhumansai:epic/8088-tinyagents-slim
Native child turns previously lost
spawn_subagentunconditionally, even when the host explicitly allowed bounded nesting. Add optionalNestedSpawnDepthadmission so a child can expose only its permitted spawn tool below the configured depth limit. Default leaf admission, denied tools, empty child sets, invalid depths and overflow remain closed.Tests cover permitted nesting, the depth cap, denied tools and the default leaf behavior. The OpenHuman integration tests exercise a real grandchild, readable refusal at the cap, and inherited Cron security policy.
Validation:
cargo test -p tinyagents-runtime— 177 passed.cargo clippy -p tinyagents-runtime --all-targets -- -D warnings— passed.Refs senamakel/openhuman#220. Part of tinyhumansai/openhuman#8088. This PR targets the epic integration branch; the final epic rollup will target
main.