Remove declarative RAG language remnants - #203
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewThis pull request removes orphaned declarative RAG language remnants across documentation, test files, error types, and capability descriptions. However, the removal is incomplete: it deletes the `TinyAgentsError::Diagnostics` variant and `RenderedDiagnostic` struct from `tinyagents-harness` without updating the `tinyagents-language` crate, causing a build failure. It also deletes the test file `language/test.rs` while leaving the corresponding production code (`build_graph`) present and untested, and removes documentation pages without updating their parent indices, creating broken links. Several documentation references to `.rag` language features should be preserved for accuracy. State: Changes requested Review snapshot
Completeness: Complete What changedRemoves declarative RAG language remnants: deletes test file, error variants, expressive-language documentation pages, and updates doc references to remove `.rag` mentions. Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. Findings
Before merge
How this fits togetherflowchart LR
n0["ModelRequestDefaults<br/>changed"]:::changed
n1["..._from_spec_round_trips_declarative_fields"]:::impacted
n2["Capability"]:::impacted
n3["...lls_toolset_middleware_and_model_defaults"]:::impacted
n1 -->|uses| n0
n1 -->|uses| n2
n2 -->|uses| n0
n3 -->|uses| n0
n3 -->|uses| n2
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (19)
✨ Finishing Touches📝 Generate docstrings
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 312655d311
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,222 +0,0 @@ | |||
| # Workspace / registry / language / definition / tracing / integration-tests review | |||
There was a problem hiding this comment.
Deleting this file leaves a broken Markdown link in docs/runtime-comparison/plan.md:11 and unresolved references in feature-gaps.md:74 and crates/tinyagents-registry/src/capability/mod.rs:110,738; readers can no longer resolve the W-* findings that the execution plan and implementation comments rely on. Preserve the still-relevant workspace/registry material or update all of these references to a surviving document.
AGENTS.md reference: AGENTS.md:L78-L80
Useful? React with 👍 / 👎.
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
Requesting changes: 1 lane(s) blocking, worst finding is critical.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0729 · 437,634 in / 24,474 out · 10,215 cached (2%) · flash, ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 1,074 embedded
critique: $0.0521 · 244,280 in / 10,537 out · 6,631 cached (3%) · gpt-5.6-luna, deepseek-v4-flash
security: $0.0185 · 88,127 in / 963 out · 0 cached (0%) · gpt-5.6-luna
tests: $0.0009 · 41,464 in / 3,075 out · 1,024 cached (2%) · deepseek-v4-flash
description: $0.0008 · 31,900 in / 6,235 out · 1,024 cached (3%) · deepseek-v4-flash
| `CapabilitySet` model resolution with fallback chains, per-tool timeouts with | ||
| grace, run limits and budgets, no-progress detection, goals and task board, | ||
| `.rag` blueprints with diagnostics, and a 637-test integration suite with | ||
| and a 637-test integration suite with |
There was a problem hiding this comment.
Preserve the .rag capability in the OpenHuman list
The preceding text lists TinyAgents/OpenHuman-owned features and currently ends with no-progress detection, goals and task board,; the deleted text was ``.rag blueprints with diagnostics, and a 637-test integration suite with. Removing the `.rag` phrase makes the document no longer claim the documented expressive-language capability, while the repository README and expressive-language documentation identify `.rag` blueprints and diagnostics as shipped TinyAgents features. Restore that phrase or update the whole sentence to accurately describe the intended ownership.
[RULE] documentation-accuracy ·
| `registry.alias_resolved` so existing host configurations can survive | ||
| component renames. |
There was a problem hiding this comment.
Preserve graph and language alias compatibility
The previous wording correctly documented that alias resolution preserves old graph specifications and expressive-language files. The new wording implies aliases are only needed for host configurations, even though named capability references in those graph and language surfaces also depend on surviving component renames. Restore the broader compatibility statement so implementers do not miss those consumers.
| `registry.alias_resolved` so existing host configurations can survive | |
| component renames. | |
| `registry.alias_resolved` so old graph specs or expressive-language files can | |
| survive component renames. |
[RULE] documentation-accuracy ·
| integration tests with `-D warnings` or without `--all-features`; | ||
| `build_graph` ignores ~70 % of a `.rag` blueprint; the language crate pulls | ||
| the HTTP stack for one error type. | ||
|
|
There was a problem hiding this comment.
Do not remove unresolved language audit caveats
The diff removes the documented caveat that build_graph ignores most of a .rag blueprint and that the language crate pulls the HTTP stack, but it contains no implementation or documentation changes resolving either issue. If these remain true, the executive summary now presents an incomplete assessment; retain the caveats or update them with the specific fixes that made them obsolete.
[RULE] inaccurate-documentation ·
tinysweeper
Bot
added
the
priority: p0
1 participant
Summary
.raglanguage tests, diagnostics, and documentationValidation
cargo fmt --checkcargo test --workspaceSummary by CodeRabbit