Skip to content

ci(e2e): add narrow Linux workflow for agent-review spec - #763

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
jwalin-shah:feat/e2e-ci-enable-agent-review
Apr 22, 2026
Merged

senamakel merged 1 commit into
tinyhumansai:mainfrom
jwalin-shah:feat/e2e-ci-enable-agent-review

Conversation

@jwalin-shah

Copy link
Copy Markdown
Contributor

Summary

  • Adds a dedicated Linux E2E workflow that runs only app/test/e2e/specs/agent-review.spec.ts under tauri-driver + Xvfb.
  • Uploads app/test/e2e/artifacts/** plus the tauri-driver log as a CI artifact when present.
  • Intentionally narrow: does not re-enable the broader commented e2e-linux matrix in test.yml.

Why a new workflow instead of uncommenting the old block

  • Smaller blast radius — rollback is just deleting this file.
  • Clearer intent — file name and job name both reference agent-review.
  • Decouples infra landing from spec landing: workflow gates on the spec's presence so it no-ops cleanly if the spec branch hasn't merged yet.

Behavior

  • Triggers: PRs touching the spec, app/test/e2e/helpers/**, app/test/wdio.conf.ts, app/scripts/e2e-*.sh, or this workflow itself; plus workflow_dispatch.
  • Gate step checks app/test/e2e/specs/agent-review.spec.ts exists — every subsequent step is skipped if not, so this PR is green on its own.
  • Build path reuses yarn workspace openhuman-app test:e2e:build + app/scripts/e2e-run-spec.sh, matching the previously-commented Linux E2E recipe.
  • Artifact upload uses if-no-files-found: ignore so empty artifact dirs don't fail the job.

Remaining risks / follow-ups

  • First real execution depends on agent-review.spec.ts landing; harness issues will only surface then.
  • Cold Cargo cache on first run will be slow but within the 60-min timeout.
  • app/test/e2e/artifacts/ is not yet written by any spec — the spec itself will need to emit there.

Test plan

  • CI green on this PR (gate skips heavy steps since spec is absent).
  • After agent-review.spec.ts lands, trigger via workflow_dispatch and verify artifact upload.

Dedicated narrow workflow that runs only agent-review.spec.ts under
tauri-driver + Xvfb and uploads app/test/e2e/artifacts/**. Gates on
spec presence so it can land before the spec itself. Intentionally does
not re-enable the broader commented E2E matrix in test.yml.
@jwalin-shah
jwalin-shah requested a review from a team April 22, 2026 06:46
@coderabbitai

coderabbitai Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@jwalin-shah has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 55 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 26 minutes and 55 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ac749b36-1acb-4c32-a729-712c7ea6aac5

📥 Commits

Reviewing files that changed from the base of the PR and between 758958b and 20ece21.

📒 Files selected for processing (1)
  • .github/workflows/e2e-agent-review.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@senamakel
senamakel merged commit 7961a32 into tinyhumansai:main Apr 22, 2026
8 of 9 checks passed
@jwalin-shah
jwalin-shah deleted the feat/e2e-ci-enable-agent-review branch April 23, 2026 21:24
AusAgentSmith pushed a commit to AusAgentSmith/openhuman that referenced this pull request May 23, 2026
Dedicated narrow workflow that runs only agent-review.spec.ts under
tauri-driver + Xvfb and uploads app/test/e2e/artifacts/**. Gates on
spec presence so it can land before the spec itself. Intentionally does
not re-enable the broader commented E2E matrix in test.yml.

Co-authored-by: Jwalin Shah <jshah1331@gmail.com>
senamakel pushed a commit to nocstah/openhuman that referenced this pull request Sep 11, 2026
…n\nDedicated narrow workflow that runs only agent-review.spec.ts under\ntauri-driver + Xvfb and uploads app/test/e2e/artifacts/**. Gates on\nspec presence so it can land before the spec itself. Intentionally does\nnot re-enable the broader commented E2E matrix in test.yml.\n\n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants