Skip to content

fix(modules): report distinct terminal failures without duplicate cached events - #7342

Draft
senamakel wants to merge 28 commits into
tinyhumansai:mainfrom
senamakel:module-terminal-sentry
Draft

senamakel wants to merge 28 commits into
tinyhumansai:mainfrom
senamakel:module-terminal-sentry

Conversation

@senamakel

Copy link
Copy Markdown
Member

Repeated callers of a cached module failure now produce one sanitized terminal event, while independent failing operations each produce their own event. A resolution completed before Sentry initialization is reported when a later cached caller has a bound client; an unfinished loader wait is not reported as terminal.

The client recognizes native module unavailability by TinyBus’s stable wire error name, preserves the existing reported-error marker, and clears request scope before reporting only module, version, stage, platform, and a closed reason code. Provider error text, arguments, credentials, and user paths stay out of these events.

Depends on #7292. GitHub rejects creation of the canonical base branch with GH013 (ref creations restricted), so this follow-up targets main and includes the foundation history. It is a draft solely until the foundation lands and the comparison can be retargeted; the reporting change itself is implemented and locally verified. Preserve granular commits when integrating.

Validation: the regression first reproduced fault/success/fault emitting one event instead of two. Independent normal-thread module suite:173 passing. Focused matrices:10 client tests with modules and crash reporting,7 with modules only,6 with crash reporting only;3 sanitization/vocabulary tests;2 cached-resolution/timeout tests in parallel. Formatting and diff checks pass. All service fixtures are local. This PR does not complete the broader module migration: released artifacts, host adapters, and removal of34 transitional exceptions and2 pending contracts remain.

senamakel and others added 27 commits October 10, 2026 14:55
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Medulla <medulla@tinyhumans.ai>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant