Skip to content

fix(openhuman-tinyhumans): drop forward of the removed peripheral-rpi feature - #6359

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:fix-peripheral-rpi-forward
Sep 19, 2026
Merged

senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:fix-peripheral-rpi-forward

Conversation

@senamakel

@senamakel senamakel commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

Summary

Problem

Two PRs each valid against the main they were opened on removed and added the same feature name; CI Lite's Rust Quality and Rust Feature-Gate Smoke jobs on main fail at dependency resolution.

Solution

Delete the forward; there is no crate behind the feature any more. Verified: cargo check -p openhuman --no-default-features, cargo check --workspace --lib --bins, cargo check --manifest-path crates/openhuman-app/Cargo.toml, and node scripts/ci/check-feature-forwarding.mjs all pass.

Submission Checklist

  • Tests added or updated — N/A: manifest/lockfile fix, verified by the build.
  • Diff coverage ≥ 80% — N/A: no source changes.
  • Coverage matrix updated — N/A.
  • All affected feature IDs listed under ## Related — N/A.
  • No new external network dependencies introduced.
  • Manual smoke checklist updated — N/A.
  • Linked issue closed — N/A.

Impact

  • Restores dependency resolution on main. openhuman-tinyhumans loses a feature name that enabled nothing.

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: fix-peripheral-rpi-forward
  • Commit SHA: f0911a2

Validation Run

  • pnpm --filter openhuman-app format:check — N/A
  • pnpm typecheck — N/A
  • Focused tests: the four commands above.
  • Rust fmt/check (if changed): as above.
  • Tauri fmt/check (if changed): cargo check --manifest-path crates/openhuman-app/Cargo.toml clean.

Validation Blocked

  • command: N/A
  • error: N/A
  • impact: N/A

Behavior Changes

  • Intended behavior change: none.
  • User-visible effect: none.

Summary by CodeRabbit

  • Removed Features
    • Removed support for the peripheral-rpi build feature from the TinyHumans package.

…add openhuman-embed

The openhuman-session dependency has been replaced with openhuman-tinyhumans in the app's lockfile, and a new openhuman-embed crate has been added as a dependency. The peripheral-rpi feature flag has been removed from the tinyhumans crate's Cargo.toml as part of this restructuring.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel requested a review from a team September 19, 2026 17:45
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8e9fed0d-b1c7-47b8-8593-1677aaf47c45

📥 Commits

Reviewing files that changed from the base of the PR and between 3669eac and f0911a2.

⛔ Files ignored due to path filters (1)
  • crates/openhuman-app/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • crates/openhuman-tinyhumans/Cargo.toml
 ___________________________________________________
< Codicem Purgo, Ergo Sum. I debug, therefore I am. >
 ---------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel merged commit eb33562 into tinyhumansai:main Sep 19, 2026
11 of 17 checks passed
@tinysweeper

tinysweeper Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Removes the forwarding of the `peripheral-rpi` feature from the `openhuman-tinyhumans` crate because the underlying feature was already removed from the `openhuman-embed` dependency, preventing a Cargo feature error and cleaning up dead configuration.

State: Ready for maintainer review
Priority: none
Reviewed head: f0911a2f902d
Updated: 1789842409 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

Removed the `peripheral-rpi` feature line from `crates/openhuman-tinyhumans/Cargo.toml`.

Features

  • Removed — peripheral-rpi feature forwarding: Removes the forwarding of the `peripheral-rpi` feature to `openhuman-embed/peripheral-rpi`, which was already removed from the dependency, preventing a potential Cargo feature error and cleaning up dead configuration. (crates/openhuman-tinyhumans/Cargo.toml)

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

security

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.
Evidence and run details
  • Models: ladder/vectors, deepseek-v4-flash
  • Spend: $0.000054
  • Tokens: 1149 input · 869 output · 0 cached · 64 embedding
Head State Pass summary
f0911a2f902d ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1789842409)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0001 · 1,149 in / 869 out · 0 cached (0%) · 64 embedded · ladder/vectors, deepseek-v4-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant