Repository navigation
fix(embed): pin reviewed OpenHuman lifecycle and cancellation fixes - #14
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This PR advances the vendored OpenHuman runtime and refreshes its dependency lockfile. No specific compatibility failure or actionable merge blocker is evidenced. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review details
Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the main change: updating the embedded OpenHuman dependency pin to include reviewed lifecycle and cancellation fixes. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the pointer with care,
A new commit now waits over there.
One tiny hop marks the change,
The trail stays clear, the path stays strange.
Then off I go, through clover and air.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Tiny Sweeper reviewTiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
1 participant
Summary
Update the OpenHuman dependency pin after Medulla #13 merged, taking the final integration fixes at
c82fa023f52c23006ffebb9498bb7ca9c3c1d63afrom merged tinyhumansai/openhuman#7347. Refresh Cargo.lock for the dependency graph without upgrading existing registry package versions.The new runtime preserves cancellation/deadline results, refuses late approvals through shared gate and RPC entry points during agent removal, preserves additive permission denials, forwards resolved hook cwd, and waits for tracked Linux descendants to stop before acknowledging cancellation. Approval closure is published before either barrier can block removal; flow workspace resolution precedes registration and generic/flow/notification surfaces are published together. These approval and closed-output descendant races have red/green regressions in OpenHuman. The runtime pin also repairs strict Rustdoc links and honors declared fleet-example build settings.
Validation
The final pin passes
make ci: formatting, strict all-target Clippy, 4,699 tests with zero failures (13 existing ignored tests), and the all-target build. The real-daemon encrypted native coordination e2e returnsCOORDINATION_OKthrough loopback mock inference. After explicitly compiling the standalone native test target,make cross-repo-testpasses all 18 spanning tests and seven prerequisite unit tests.The final OpenHuman source passes 230 selected embed tests, seven production registration-scope/flow-coordinator tests, one process-state parser test, strict embed Clippy and minimal-feature core Clippy with allowances for existing unused imports/variables. Changed Rust production coverage is 88.85% of 296 lines. Generated default-capability documentation, formatting, layout, coverage matrix and 24 focused docs/runner/consumer-contract tests pass. Strict default-feature Rustdoc and the actual 100-agent release fleet run pass.
Related
Summary by CodeRabbit