oci2disk: add the ability to pass the compression algorithm via the C…#169
Open
thees wants to merge 2 commits intotinkerbell:mainfrom
Open
oci2disk: add the ability to pass the compression algorithm via the C…#169thees wants to merge 2 commits intotinkerbell:mainfrom
thees wants to merge 2 commits intotinkerbell:mainfrom
Conversation
49fddf4 to
2abddc4
Compare
…OMPRESSED environment variable so that the image tag does not need to have the compression extension as a "file extension". still keep the backward compatibility with COMPRESSED=true so that the imageUrl (i.e. the image tag) is parsed for the compression algorithm Signed-off-by: Sebastian Thees <thees@users.noreply.github.com>
Signed-off-by: Sebastian Thees <thees@users.noreply.github.com>
2abddc4 to
6029d39
Compare
Author
|
Hi @jacobweinstock , I don't know about the process, but take a look at this PR which removes the requirement to have images tagged with the file extension at the end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…OMPRESSED environment variable so that the image tag does not need to have the compression extension as a "file extension". still keep the backward compatibility with COMPRESSED=true so that the imageUrl (i.e. the image tag) is parsed for the compression algorithm
Description
Change affects the action oci2disk:
Currently the compression type needs to be in the image tag as a suffix which is a design flaw in my opinion.
This PR gives the user the ability to pass the compression type of the image by using the existing COMPRESSED env variable.
Backward compatibility is kept with COMPRESSED=true. If true, the code tries to detect the compression type the old way (the suffix of the image url, which is in most cases the "suffix" of the image tag)
Documentation is clearer now as well.
Fixes: #
How Has This Been Tested?
new unit tests for this small change, so that the given variable is respected correctly
How are existing users impacted? What migration steps/scripts do we need?
Backward compatibility is kept. Users can additionally pass the compression by using the existing COMPRESSED variable.
Checklist:
I have: