feat(api): add SCREENSHOT_API_SECRET to environment and use it in screenshot requests#892
feat(api): add SCREENSHOT_API_SECRET to environment and use it in screenshot requests#892B-a-l-aj-i wants to merge 7 commits intodevfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a required server env var Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/env/server.ts`:
- Line 18: Add a placeholder for SCREENSHOT_API_SECRET to the .env.example
SECURITY section so local startups don't fail; update the SECURITY block to
include an entry like SCREENSHOT_API_SECRET=<placeholder> with a short comment
describing its purpose (e.g., "API secret for screenshot service") so developers
know to set it before running code that reads SCREENSHOT_API_SECRET from
src/env/server.ts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: fabe01f0-c0a2-44f9-97e4-86bb7ebd8668
📒 Files selected for processing (3)
src/env/server.tssrc/pages/api/bookmark/add-url-screenshot.tssrc/pages/api/v1/screenshot.ts
In port 3001 screenshot api is running, the screenshot api need's a secret to process request.recollect-screenshot-test-secret-1774858670375.mp4Note: Need to update vercel env after merging. |
navin-moorthy
left a comment
There was a problem hiding this comment.
Also need to change in V2 endpoints
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.env.example:
- Line 99: The file `.env.example` is missing a trailing newline after the last
entry `SCREENSHOT_API_SECRET=your-screenshot-api-secret`; open `.env.example`
and add a single newline character (blank line) at EOF so the file ends with a
trailing newline to satisfy dotenv-linter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5d9c16bd-d689-4365-a18c-f85318de32d1
📒 Files selected for processing (5)
.env.examplesrc/app/api/v2/bookmark/add-url-screenshot/route.tssrc/app/api/v2/screenshot/route.tssrc/pages/api/v1/screenshot.tsturbo.json
✅ Files skipped from review due to trivial changes (2)
- src/pages/api/v1/screenshot.ts
- turbo.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit