Skip to content

conflict with rack-test and at_exit hook issues - #34

Open
lucashungaro wants to merge 2 commits into
thumblemonks:masterfrom
lucashungaro:master
Open

conflict with rack-test and at_exit hook issues#34
lucashungaro wants to merge 2 commits into
thumblemonks:masterfrom
lucashungaro:master

Conversation

@lucashungaro

Copy link
Copy Markdown
Contributor

I was trying to setup Riot + rack-test in a Rails app and got name conflicts with the options method, so I renamed it to option_set.

The second commit is to prevent an issue where a Rake::TestTask always reports a failure, despite the tests passing. I'm not sure I understood what you were trying to accomplish there, so feel free to fix it in a different way, of course. :)

@achiurizo

Copy link
Copy Markdown
Contributor

i've pulled in your "conflict with rack-test" change here: 4008ad1. For the at_exit hook change, i was unable to reproduce the error. I've encountered this error before but @jaknowlden and I recall that the code that exists there was to address this issue specifically. Thanks for the commit regardless. I'll keep an eye out and continue to see if this issue still pops up. I'm in the #riot irc room if you want to continue diving in this issue further. Thanks!

@lucashungaro

Copy link
Copy Markdown
Contributor Author

Ok, I'll reinstall Ruby from scratch and try again.

@lucashungaro

Copy link
Copy Markdown
Contributor Author

Ok, reinstalled Ruby 1.9.2 and tried again. Got the same errors.

@achiurizo

Copy link
Copy Markdown
Contributor

Ok, i'll take a look again.

@achiurizo

Copy link
Copy Markdown
Contributor

@lucashungaro is the rake test failure still an issue? @jaknowlden any ideas?

@gus

gus commented Aug 25, 2011

Copy link
Copy Markdown
Member

I'll take a look this afternoon.

Justin Knowlden

On Wednesday, August 24, 2011 at 11:36 PM, achiu wrote:

@lucashungaro is the rake test failure still an issue? @jaknowlden any ideas?

Reply to this email directly or view it on GitHub:
#34 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants