Conversation
Add NullableShortString type to common schemas that accepts either a string (max 1024 chars) or null. Uses f/anything with a registered nilable spec to work around Flanders lacking native nullable support. Update incident schema to use NullableShortString for short_id, add nil short_id example, and add test coverage for the nullable case.
devn
requested review from
brookeswanson,
ereteog,
frenchy64,
gbuisson,
marioaquino,
msprunck,
safi,
samwagg,
turbodog99 and
yogsototh
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NullableShortStringtype toctim.schemas.commonthat accepts a string (max 1024 chars) or nullf/anythingwith a registered nilable spec to work around Flanders lacking native nullable supportshort_idfield to useNullableShortStringTest plan
lein test :no-genpasses (43 tests, 416 assertions, 0 failures)