Reports a browser job error for an HTTP error response#868
Merged
Conversation
thp
requested changes
Jul 7, 2026
thp
left a comment
thp
left a comment
Owner
There was a problem hiding this comment.
See comments. I think it's worthwhile to make the desired behaviour the default, as the option is otherwise a "fix the (buggy) legacy behavior" toggle that new users need enable to fix behaviour.
For consistency, having ignore_http_error_codes like UrlJob seems like a good idea.
We can always add spacebar heating back as an option later if someone complains (or not..).
trevorshannon
commented
Jul 8, 2026
thp
requested changes
Jul 9, 2026
thp
left a comment
thp
left a comment
Owner
There was a problem hiding this comment.
Just minor style and wording comments to make it super clean. Rest looks good now. Thanks for working on this!
trevorshannon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a browser job option
raise_for_statusthat, when true, will raise an error if the response has an HTTP error status. Omitting the option results in the same behavior as before this change.Once the browser navigates to the page of interest (following any redirects), if the resulting HTTP status code is not in the range 200-299, an error is raised. This error is reported the same as an HTTP error in a
urljob: no traceback, showing only the status code & message.This is particularly useful for keeping temporary
404or500errors from polluting the job history for browser jobs.fixes #867