Allow reporters to be specified multiple times#822
Merged
Conversation
Jamstah
force-pushed
the
multiple-reporters
branch
from
May 29, 2024 22:40
bb8fa04 to
8564853
Compare
Jamstah
marked this pull request as draft
May 29, 2024 22:44
Jamstah
force-pushed
the
multiple-reporters
branch
2 times, most recently
from
May 29, 2024 22:52
aafd0a6 to
7cf98cc
Compare
Jamstah
marked this pull request as ready for review
May 29, 2024 22:57
thp
requested changes
Jul 30, 2024
Jamstah
force-pushed
the
multiple-reporters
branch
4 times, most recently
from
August 5, 2024 10:13
a02231b to
4c82895
Compare
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses. Closes thp#790 Signed-off-by: James Hewitt <james.hewitt@gmail.com>
Jamstah
force-pushed
the
multiple-reporters
branch
from
August 5, 2024 10:14
4c82895 to
956cd2f
Compare
thp
requested changes
Sep 20, 2024
thp
requested changes
Jul 7, 2026
thp
left a comment
thp
left a comment
Owner
There was a problem hiding this comment.
Getting there. Some minor comments.
thp
reviewed
Jul 8, 2026
thp
reviewed
Jul 8, 2026
thp
requested changes
Jul 8, 2026
thp
left a comment
thp
left a comment
Owner
There was a problem hiding this comment.
Only minor rewording requests, the rest looks good now. Thanks for working on this!
Co-authored-by: Thomas Perl <m@thp.io>
thp
approved these changes
Jul 9, 2026
thp
left a comment
thp
left a comment
Owner
There was a problem hiding this comment.
Looks clean now.
Thanks for unifying submit_all() and submit_one(), that's a nice cleanup I just now saw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows different jobs to be selected for reporting in different ways, for example, allowing different changes to be emailed to different addresses.
Closes #790