[SKIP CI] run-all-test: make similar test cases with pr test#1019
[SKIP CI] run-all-test: make similar test cases with pr test#1019fredoh9 wants to merge 1 commit intothesofproject:mainfrom
Conversation
run-all-test.h provides a good way to do local sanity tests. This change is to accommodate a known pr test plan. +kernel-boot-log +playback_all_formats +capture_all_formats +runtime-pm-status +multiple-pipeline-all -volume -xrun-injection-playback -xrun-injection-capture Signed-off-by: Fred Oh <[email protected]>
|
Is it too late to switch the underscores to dashes in the file names, to match the formatting everywhere else? |
| exit 1 | ||
| } | ||
|
|
||
| test_kernel-boot-log() |
There was a problem hiding this comment.
I agree with @greg-intel , please no mix in the same name.
| test_kernel-boot-log() | |
| test_kernel_boot_log() |
There was a problem hiding this comment.
I'm leaning towards renaming the few tests that have underscores to be dashes, as 95% of our tests are named using dashes. I'm not sure how the underscore tests got through, I don't remember seeing them...
There was a problem hiding this comment.
I'm leaning towards renaming the few tests...
Consistency and simplicity are good and should absolutely be a goal for new code or code that is changing anyway for other reasons.
For unchanged code it's much more questionable. Is it worth the git churn and potential git conflicts with PRs in progress, branches, etc? It depends.
3 participants
run-all-tests.sh provides a good way to do local sanity tests. This change is to accommodate a known pr test plan.
+kernel-boot-log
+playback_all_formats
+capture_all_formats
+runtime-pm-status
+multiple-pipeline-all
-volume
-xrun-injection-playback
-xrun-injection-capture
I put 'SKIP CI', run-all-test.sh is not part of device test.