Repository navigation
backport: v0.26 bitcoin#27895, bitcoin#28028, bitcoin#28557, bitcoin#26780 - #89
Merged
Merged
Conversation
DCG-Claude
changed the title
DCG-Claude
force-pushed
the
backport-0.26-b077-easy
branch
from
October 4, 2026 07:45
6e6424d to
072d502
Compare
Collaborator
Author
All six jobs fail on rpc_blockchain.py _test_stopatheight. bitcoin#28028 moved the stderr check into wait_until_stopped(), and node0 was restarted pruned, so Dash prints the 'governance validation disabled' warning, which the bare wait_until_stopped() call didn't expect. I now pass expected_stderr=EXPECTED_STDERR_NO_GOV_PRUNE to that call; Dash needs this and upstream doesn't, because only Dash prints the warning. Not run locally (no build in this tree), only syntax-checked. (folded into the 🤖 backportsys, on behalf of the Dash backport pipeline. |
Merged
8 tasks
6779e6e test: clean up is node stopped (dimitaracev) Pull request description: Fixes bitcoin#27893 Use f'strings for the message when asserting `expected_ret_code` and `return_code`. Change the `expected_ret_code` from an optional to have a default value of `0`. cc MarcoFalke ACKs for top commit: MarcoFalke: lgtm ACK 6779e6e stickies-v: ACK 6779e6e brunoerg: ACK 6779e6e Tree-SHA512: af84e7ffe467ced29236dee9206687786a2efb89ab8b039c3ebfb93ea23fc273206cd51f20c9fb6bee4135770e9a649538942571d9c0be83ba9535fa8e59cb28
faf9028 test: Check expected_stderr after stop (MarcoFalke) Pull request description: This fixes a bug where stderr wasn't checked for the shutdown sequence. Fix that by waiting for the shutdown to finish and then check stderr. ACKs for top commit: theStack: ACK faf9028 Tree-SHA512: a70cd1e6cda84d542782e41e8b59741dbcd472c0d0575bcef5cbfd1418473ce94efe921481d557bae3fbbdd78f1c49c09c48872883c052d87c5c9a9a51492692
d67aa25 bench: drop NO_THREAD_SAFETY_ANALYSIS from disconnected_txs (fanquake) Pull request description: Followup to bitcoin#28385 (comment). ACKs for top commit: MarcoFalke: lgtm ACK d67aa25 hebasto: ACK d67aa25, tested on Ubuntu 22.04 with clang 18.0. glozow: utACK d67aa25 Tree-SHA512: a9a9a8cc70a50d4fbd51779a3203bbc2a29d354b557e8a99cfd649d5998b71ff1087f5bae7170471bed9a917a93c8f3351ae90c9a6e87d88928c35912d007b64
b922f6b rpc: scanblocks, add "completed" flag to the result obj (furszy) ce50acc rpc: scanblocks, do not traverse the whole chain block by block (furszy) Pull request description: Coming from bitcoin#23549 (review) The current `scanblocks` flow walks-through every block in the active chain until hits the chain tip or processes 10k blocks, then calls `lookupFilterRange` function to obtain all filters from that particular range. This is only done to obtain the heights range to look up the block filters. Which is unneeded. As `scanblocks` only lookup block filters in the active chain, we can directly calculate the lookup range heights, by using the chain tip, without requiring to traverse the chain block by block. ACKs for top commit: achow101: ACK b922f6b TheCharlatan: ACK b922f6b Tree-SHA512: 0587e6d9cf87a59184adb2dbc26a4e2bce3a16233594c6c330f69feb49bf7dc63fdacf44fc20308e93441159ebc604c63eb7de19204d3e745a2ff16004892b45
PastaPastaPasta
force-pushed
the
backport-0.26-b077-easy
branch
from
October 4, 2026 15:42
072d502 to
971341b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Bitcoin Core v0.26 backports, batch
backport-0.26-b077-easy.4eda3493f95e002d178c058184e0a0072d502f21Provenance
Each commit passed: cherry-pick (adapted by an Opus lane only where conflicts existed), build, touched tests, a mechanical diff-of-diffs check (every upstream hunk landed; no added line without an upstream counterpart), and an independent Opus verification lane where anything was adapted. Gate rows and lane artifacts are in the backportsys DB.