Repository navigation
backport: v0.27 bitcoin#28363, bitcoin#29518, bitcoin#29052, bitcoin#23171 - #123
Open
DCG-Claude wants to merge 4 commits into
Open
DCG-Claude wants to merge 4 commits into
DCG-Claude wants to merge 4 commits into
Conversation
3c208cc Add offline signing tutorial (Brandon Odiwuor) Pull request description: This PR adds offline signing tutorial. Fixes bitcoin#9492 Although there currently exists tutorials on external-signer and on multisig implemented on bitcoin#24519 . The external-signer tutorial assumes a connected device and the multisig tutorial is only for multisig transactions and does not include using an offline wallet - The tutorial uses signet(instead of regtest) to be as close as possible to mainnet ACKs for top commit: achow101: ACK 3c208cc willcl-ark: ACK 3c208cc pinheadmz: ACK 3c208cc Zero-1729: ACK 3c208cc Tree-SHA512: c1686043d9e9ed440e78d219a6b18d58d62efd05bdd535e74194d8cc2db0a91e94c6c619106453120a137e47220cf3ab27af3214e861f4e5cc419a73a8704dd6
…docs efb70cd doc: correct function name in AssumeUTXO design docs (jrakibi) Pull request description: Corrected the function name from `CompleteSnapshotValidation()` to `MaybeCompleteSnapshotValidation()` in the assumeutxo design documentation. This change ensures that the documentation accurately reflects the actual function name used in the code ACKs for top commit: Empact: ACK bitcoin@efb70cd Tree-SHA512: 68b9be3ba710d91a2a955189e227f86b46ccb6a2a13c345d46f276cec6ff12b77ebf9814c4bcb00db7c17e221510e4a2e71175c78a6faf0e0e3159c761bc9b94 Dash adaptations: - doc/design/assumeutxo.md: function-name fix already in Dash via 9cfc65a, which also dropped upstream's stray ')'; kept Dash's line and EvoDB paragraph
…connection count d58f89d doc: update/clarify max outbound connection count (Marnix) Pull request description: closes bitcoin#29046 ACKs for top commit: amitiuttarwar: ACK d58f89d brunoerg: ACK d58f89d Tree-SHA512: 4f6e8596ceea0b655338b3fc90a465e319d81e2a006f22a98cd9acada9316e7eb2340e2f66b1b4dde4e63ae94f57efddec50478715608e1be3212b8e2d1c3a1a
…pubkeys 36012ef qa: test descriptors with mixed xpubs and const pubkeys (Antoine Poinsot) Pull request description: Writing unit tests for Miniscript descriptors i noticed that `test/descriptor_tests`'s `DoCheck()` assumes that a descriptor would either contain only extended keys or only const pubkeys: if it detects an xpub in the descriptor it would assert the number of cached keys is equal to the number of keys in the descriptor, which does not hold if the descriptor also contains const (raw?) public keys since we only cache parent xpubs. ACKs for top commit: achow101: ACK 36012ef Tree-SHA512: 2ede67a6dff726bcad3e260f3deb25c9b77542ed1880eb4ad136730b741014ce950396c69c7027225de1ef27108d609bafd055188b88538ace0beb13c7e34b0b Dash adaptations: - src/test/descriptor_tests.cpp: new Check() calls drop upstream's norm_prv argument; Dash's Check() takes (prv, pub, norm_pub, ...) - src/test/descriptor_tests.cpp: the non-range mixed case uses sh(multi(...)) with P2SH script a914917bae893e42c19dcf19bfe844514482c1f4fd2487 and OutputType::LEGACY, since Dash has no segwit/wsh() - src/test/descriptor_tests.cpp: the mixed test descriptors use Dash's WIF XJvEUEcF... for the same compressed key, instead of Bitcoin's L4rK1y...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Bitcoin Core v0.27 backports, batch
backport-0.27-b015-misc.cfc1071c6b0d7dc385bb0f94dc0af6fa7bbd97fcProvenance
Each commit passed: cherry-pick (adapted by an Opus lane only where conflicts existed), build, touched tests, a mechanical diff-of-diffs check (every upstream hunk landed; no added line without an upstream counterpart), and an independent Opus verification lane where anything was adapted. Gate rows and lane artifacts are in the backportsys DB.