Repository navigation
backport: v0.27 bitcoin#28503 - #116
Open
DCG-Claude wants to merge 1 commit into
Open
DCG-Claude wants to merge 1 commit into
DCG-Claude wants to merge 1 commit into
Conversation
…, use SER_PARAMS_OPFUNC 9999019 Remove WithParams serialization helper (MarcoFalke) ffffb4a scripted-diff: Use ser params operator (MarcoFalke) fae9054 test: Use SER_PARAMS_OPFUNC in serialize_tests.cpp (MarcoFalke) Pull request description: Every serialization parameter struct already has the `SER_PARAMS_OPFUNC`, except for one in the tests. For consistency, and to remove verbose code, convert the test to `SER_PARAMS_OPFUNC`, and use it everywhere, then remove the `WithParams` helper. ACKs for top commit: ajtowns: reACK 9999019 TheCharlatan: Re-ACK 9999019 Tree-SHA512: be9cae4225a502486fe8d552aaf4b2cd2904a9f73cce9d931c6b7c757594ff1982fcc2c30d00d012cd12b0a9531fd609f8bcd7c94b811e965ac087eb8a3589d3 Dash adaptations: - src/test/serialize_tests.cpp: upstream's BaseFormat struct and RAW/HEX constants follow Dash-only UnserializeVectorWithMaxSize/LimitedVectorFormatter tests, which are kept - src/evo/deterministicmns.h: Dash-only GetUniquePropertyHash() now uses ser_params(v) instead of the removed WithParams(ser_params, v)
DCG-Claude
changed the title
DCG-Claude
force-pushed
the
backport-0.27-b004-src-test
branch
from
October 21, 2026 19:20
bb4f330 to
0946e87
Compare
Collaborator
Author
|
Branch rewritten at
🤖 backportsys, on behalf of the Dash backport pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Bitcoin Core v0.27 backports, batch
backport-0.27-b004-src-test.0946e87219Provenance
Each commit passed: cherry-pick (adapted by an Opus lane only where conflicts existed), build, touched tests, a mechanical diff-of-diffs check (every upstream hunk landed; no added line without an upstream counterpart), and an independent Opus verification lane where anything was adapted. Gate rows and lane artifacts are in the backportsys DB.