Update bundle courses view in student dashboard#2863
Merged
Conversation
harunollyo
requested changes
Jul 3, 2026
| public static function get_completed_courses_by_user( $user_id = 0, $offset = 0, $posts_per_page = -1, $args = array() ) { | ||
| $user_id = tutor_utils()->get_user_id( $user_id ); | ||
| $course_ids = tutor_utils()->get_completed_courses_ids_by_user( $user_id ); | ||
| $course_ids = tutor_utils()->get_completed_courses_ids_by_user( $user_id, false ); |
Collaborator
There was a problem hiding this comment.
This method is used in several places, we need to ensure all the called places context before passing 2nd param false.
| public static function get_active_courses_by_user( $user_id = 0, $offset = 0, $posts_per_page = -1, $args = array() ) { | ||
| $user_id = tutor_utils()->get_user_id( $user_id ); | ||
| $course_ids = tutor_utils()->get_completed_courses_ids_by_user( $user_id ); | ||
| $course_ids = tutor_utils()->get_completed_courses_ids_by_user( $user_id, false ); |
harunollyo
requested changes
Jul 6, 2026
|
|
||
| $courses_tab = ( new Student() )->get_courses_tab( $active_tab, $post_type_args, $enrolled_course_count, $active_course_count, $completed_course_count ); | ||
| // Separate count queries with no offset so tab counts are always accurate regardless of current page. | ||
| $enrolled_courses_for_count = CourseModel::get_enrolled_courses_by_user( get_current_user_id(), array( 'private', 'publish' ), 0, 1 ); |
Collaborator
There was a problem hiding this comment.
Use constant instead of string
harunollyo
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.