Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
Also scala-java-time 2.11.0 (built with Scala 3.9) and -Xkind-projector (-Ykind-projector is deprecated on Scala 3.9). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
…ons) One shared hearth implementation for 2.13 and 3.9. Values are built through the companion's apply, so validating/normalising apply methods now apply on Scala 3 too (kebs 2 used Mirror.fromProduct there, which bypassed them). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
A Scala 3 Mirror exists for single-field case classes with a private or protected constructor or a private field. The macro used to abort after the Mirror guard had selected the implicit - a hard compile error, or inside circe's inline derivation a silent switch from flat to object JSON. It now falls back to Mirror.fromProduct / productElement for what hearth cannot build or read (kebs 2's Scala 3 behaviour); the companion apply is still tried first. Scala 2 keeps aborting silently (no instance). Adds selection tests that tell 'no instance' from 'hard error', and private-constructor value-class goldens for circe, spray-json and play-json (captured against v2.3.0 on 2.13.18 and 3.3.9). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K
This was referenced Nov 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR of the kebs 3 rewrite: macros on hearth / kindlings, Scala 2.13 + 3.9, one implementation per macro. kebs 2.x continues on
series/2.x(cut at v2.3.0).What changes
tlBaseVersion3.0, MiMa off for 3.0.0,-Xkind-projector,-Xsource:3on 2.13.org.typelevel, packageorg.typelevel.doobie) and scala-java-time 2.11.0 (both need the new Scala 3 floor).kebs-pekko-http; docs page renamed topekko-http.md.ValueClassLikeon hearth: one shared macro for 2.13 and 3 (thin per-version entry points). Values are built through the companionapply, so validating/normalisingapplys now apply on Scala 3 too (kebs 2 usedMirror.fromProductthere). On Scala 3, types the macro cannot build or read (private/protected constructor, private field) fall back to theMirror, as in kebs 2 — the implicit never fails after theMirrorguard selected it.kebs-testkit(test-only, unpublished cross-project) with shared models, and golden tests pinning the kebs 2.x JSON of circe (12), spray-json (12) and play-json (7). They were verified against v2.3.0 (old macros, 2.13.18 and 3.3.9) before being used to check the new code.Verification
docs/mdocbuilds.Behaviour changes to note in the 3.0 migration guide
applyis now honoured byValueClassLikeon Scala 3 (decoding values that fail it now fails instead of bypassing it).Known follow-ups (deferred review minors)
-Wconf:cat=scala3-migration:scould be:w; constructor fallback visibility (EverywherevsAtCallSite); hearth's "not a case class" reason is not surfaced; anapply(F)returning non-Tis skipped; circe/play goldens compare structurally (field order not pinned); Akka still mentioned inwebsite/srcand.scala-steward.conf; kebs-core on 2.13 bringsscala-compilervia hearth (release note). Theexamplesproject was already broken before this PR and is not built in CI.🤖 Generated with Claude Code
https://claude.ai/code/session_01DFD5QTj91bQhcjiNo9n48K