Skip to content

chore: clean up typing and linter issues - #989

Merged
Khunkurisu merged 20 commits into
release-3.2.0from
chore/clean-up-typing-and-linter-issues-#984
Nov 4, 2026
Merged

Khunkurisu merged 20 commits into
release-3.2.0from
chore/clean-up-typing-and-linter-issues-#984

Conversation

@Khunkurisu

@Khunkurisu Khunkurisu commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)

  • Bug fix
  • Feature
  • Refactor
  • Other (please describe):

Description
Resolves the vast majority of linting issues that are not themselves genuine bugs in our code.

Related Issue
Closes #984

How Has This Been Tested?

  1. Check out release-3.2.0
  2. Open terminal in project root and run npx eslint
  3. See many errors
  4. Check out this branch
  5. Repeat step 2
  6. Note substantial reduction in error count

Screenshots (if applicable)
Before:
image
After:
image

Checklist:

  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce any new warnings or errors.
  • My PR does not contain any copyrighted works that I do not have permission to use.
  • No part of this PR was created using generative AI tools.
  • I have tested my changes on Foundry VTT version: 13.351.

Additional context
These changes produce equivalent code output on build where reasonable.

@Khunkurisu Khunkurisu changed the title chore/clean up typing and linter issues chore: clean up typing and linter issues Oct 22, 2026
@Khunkurisu Khunkurisu self-assigned this Oct 22, 2026
@Khunkurisu
Khunkurisu force-pushed the chore/clean-up-typing-and-linter-issues-#984 branch from 9c7cdf7 to 35c9510 Compare October 22, 2026 21:24
@Khunkurisu
Khunkurisu force-pushed the chore/clean-up-typing-and-linter-issues-#984 branch from 35c9510 to 8a6a674 Compare October 22, 2026 22:50
@Khunkurisu
Khunkurisu force-pushed the chore/clean-up-typing-and-linter-issues-#984 branch 2 times, most recently from b37d46e to cae1eea Compare October 22, 2026 23:31
@Khunkurisu
Khunkurisu marked this pull request as draft October 22, 2026 23:44
@Khunkurisu
Khunkurisu force-pushed the chore/clean-up-typing-and-linter-issues-#984 branch from c0b19d7 to 05e99e6 Compare November 2, 2026 19:11
@Khunkurisu
Khunkurisu force-pushed the chore/clean-up-typing-and-linter-issues-#984 branch from 05e99e6 to b384090 Compare November 2, 2026 20:13
@Khunkurisu
Khunkurisu force-pushed the chore/clean-up-typing-and-linter-issues-#984 branch from b384090 to 9086174 Compare November 2, 2026 20:17
@Khunkurisu
Khunkurisu force-pushed the chore/clean-up-typing-and-linter-issues-#984 branch from 5f917d2 to 556d527 Compare November 2, 2026 21:28
@Khunkurisu
Khunkurisu marked this pull request as ready for review November 2, 2026 21:46
@Khunkurisu
Khunkurisu requested review from a team as code owners November 2, 2026 21:46
Comment thread .github/workflows/pr.yml Resolved
Comment thread .github/workflows/pr.yml Resolved
Comment thread src/system/documents/item.ts Resolved
Comment thread src/system/utils/talent-tree.ts Resolved
@Khunkurisu
Khunkurisu force-pushed the chore/clean-up-typing-and-linter-issues-#984 branch from 973ed9e to 8aca14a Compare November 3, 2026 19:16
@Khunkurisu
Khunkurisu merged commit 5702bcf into release-3.2.0 Nov 4, 2026
@Khunkurisu
Khunkurisu deleted the chore/clean-up-typing-and-linter-issues-#984 branch November 4, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants