Repository navigation
Conversation
…l associations on actions
Since I went a different direction by letting resourceConfig hold the values for default and valid modes, this can be cleaned up and made nicer.
Since derived-value-field no longer defines what is valid/default for resource fields, we can add range to derived.modes.
This works as both a default and a validator. Given we assume derived is always the default mode if derived is available, Which I believe we dont intend to change. If we do want to make it truly set the default, we can simply add a "none" to the resource Derived.Mode which will then be the new "default" value and then promptly be overrid by the sanitize method.
* feat: add scalar table for knucklebones * feat: add knucklebones embedded action
* Added simple updateResourceMax function to actor sheet testing helper * Removed dead playwright config file * Started adding Adversary resource configuration test * Patched updateResourceMax to filter to the correct per-resource window * Added more resource config tests, including configuring health ranges
* fix(handlebars): use non-deprecated loadTemplates() location Signed-off-by: Khunkurisu <creative.3d@live.com> * fix(chat message): use renderHTML method instead of getHTML Signed-off-by: Khunkurisu <creative.3d@live.com> * fix(handlebars): use non-deprecated renderTemplate() location Signed-off-by: Khunkurisu <creative.3d@live.com> * fix(text editor): use .implementation and non-deprecated location Signed-off-by: Khunkurisu <creative.3d@live.com> * fix(file picker): use .implementation and non-deprecated location Signed-off-by: Khunkurisu <creative.3d@live.com> * fix(compendium collection): use non-deprecated location Signed-off-by: Khunkurisu <creative.3d@live.com> * fix(talent trees): use non-deprecated loadTexture() location * fix(drag-drop): use .implementation and non-deprecated location --------- Signed-off-by: Khunkurisu <creative.3d@live.com>
* chore: actually give useful non-copy-pasted comment to getRegisteredRollData method * feat: refactor config data to be a method which takes in the actor document and returns a value
…bout old signature
also hide placeholders if you can't edit sheet
… immunities and tabs
…ne another (#982) * Made all prerequisite option data structures except level able to hold multiple ORed options * First-pass of new prereq approach migration * Started adding UI for prerequisites * Fixed talent-tree-node-collection fields * Fixed 3.1-3.2 migration * Fixed item references in prerequisite-item-list.ts * Fixed node tooltips for new structure * Made edit prerequisite rule dialog respect all item-dropping prerequisites * Return "undefined" for item lists on null/undefined prereqs * Add UI for multi-item skill/attribute requirements on editing prerequisites * Removed dead node-prerequisite-goal/talent-list files
Khunkurisu
previously requested changes
Oct 20, 2026
Khunkurisu
left a comment
Contributor
There was a problem hiding this comment.
Okay I maybe went a bit overboard here. Even if you disregard the actual suggested changes, the bare minimum is breaking up your defaults into a base, character, and adversary object each and recombining them as needed. There is absolutely no reason to repeat the shared keys for both, that is just begging for someone to change only one when making an update and we really don't need more of those problems.
This has some problems like being unable to decide the order of the settings completely.
The current refactor did remove the functionality to choose the order of how the settings will appear. This fixes that.
Khunkurisu
force-pushed
the
release-3.2.0
branch
from
October 22, 2026 15:33
fb90814 to
85bbdda
Compare
Khunkurisu
force-pushed
the
release-3.2.0
branch
2 times, most recently
from
October 22, 2026 22:50
ebf669b to
2bb00b0
Compare
Khunkurisu
force-pushed
the
release-3.2.0
branch
from
November 2, 2026 20:17
bbf9bf0 to
2e6466e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)
Description
Mainly aims to make limited ownership grant limited information. What this information can be is ultimately up to the GM who can set this in the settings.
This does not affect the chat messages, so information such as bonuses, target defenses and such are not hidden unless the roll itself is hidden. I figured this was not really too relevant to this PR.
Also refactors how adversary section data is handled to be less hard coded since it now has to facilitate the now plausible situation where the adversary action tab does not contain at least 3 sections.
Testing this is kinda lengthy so I'll go through how I've been testing it myself.
Related Issue
Closes #582
How Has This Been Tested?
Initial Test Setup
Configuration Testing
Screenshots (if applicable)
Add screenshots or GIFs that help illustrate the changes, especially if they affect the UI or user-facing aspects of the system.
Default
This is the default look for a character sheet with limited view


This is the default look for an adversary sheet with limited view
Minimum Info
This is how a character sheet looks if you hide everything possible:

This is how an adversary sheet looks if you hide everything possible:

Maximum Info
It looks the same as it currently does
Checklist:
Additional context
Currently waiting for release 3.2.0 branch