Skip to content

feat(actor sheets): handle limited ownership visibility - #980

Open
dtfe wants to merge 62 commits into
release-3.2.0from
limited-ownership-visibility-#582
Open

dtfe wants to merge 62 commits into
release-3.2.0from
limited-ownership-visibility-#582

Conversation

@dtfe

@dtfe dtfe commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)

  • Bug fix
  • Feature
  • Refactor
  • Other (please describe):

Description
Mainly aims to make limited ownership grant limited information. What this information can be is ultimately up to the GM who can set this in the settings.

This does not affect the chat messages, so information such as bonuses, target defenses and such are not hidden unless the roll itself is hidden. I figured this was not really too relevant to this PR.

Also refactors how adversary section data is handled to be less hard coded since it now has to facilitate the now plausible situation where the adversary action tab does not contain at least 3 sections.

Testing this is kinda lengthy so I'll go through how I've been testing it myself.

Related Issue
Closes #582

How Has This Been Tested?

Initial Test Setup

  1. Create character
  2. Give actor ancestry, culture and path
  3. Set level to 4
  4. Give path 3 talents so it is at 4 total
  5. Give some random attribute numbers, skill numbers, etc.
  6. Give some random expertises and immunities
  7. Give some random items
  8. Equip a weapon item so you get the action
  9. Then set ownership to owner as default
  10. Duplicate character and make the new default ownership of duplicate as "observer"
  11. Duplicate observer character and make it limited ownership
  12. Repeat steps 1-11 for adversary as well or use pre existing adversaries from one of the world guide that has all of the required elements listed in the steps above
  13. Create new player for world

Configuration Testing

  1. Go to configure settings, cosmere roleplaying game and the top setting should be a button that says Configure Ownership visibility
  2. Click and check that the following default settings exist:
  • Attributes (True both)
  • Defenses (True both)
  • Level (True both)
  • Resources (False both)
  • Skills (True both)
  • Expertises (True both)
  • Immunities (False both)
  • Ancestry (True Character, No Adversary)
  • Culture (True Character, No Adversary)
  • Path (True Character, No Adversary)
  • Talents tab (False Character, No Adversary)
  • Actions tab (False Character, No Adversary)
  • Equipment tab (False both)
  • Goals tab (False Character, No Adversary)
  • Notes tab (True Both)
  • Apperance (True Both)
  • Biography (False Both)
  • Notes (False Both)
  • Effects tab (True Both)
  • Adversary Features (No Character, False Adversary)
  • Adversary Actions (No Character, False Adversary)
  1. Hide everything (Ensure everything is false) and Save
  2. Log out and go into player account
  3. Go on the character sheet and check the below
  4. Check limited and ensure the only information the player user can see is the vague health bars, portrait and name. Everything else is either ?, Unknown or not visible.
  5. Ensure you cant roll skills or click on anything related to the sheet
  6. Check Observer and see that all the information is there as it should be and check if you can roll anything.
  7. Check Owner and see that you have access to everything as you should.
  8. Do the same for Adversary
  9. Go back to settings and press Reset Defaults
  10. Open settings back up again and see that it has gone back to the default settings

Screenshots (if applicable)
Add screenshots or GIFs that help illustrate the changes, especially if they affect the UI or user-facing aspects of the system.

Default

This is the default look for a character sheet with limited view
image
This is the default look for an adversary sheet with limited view
image

Minimum Info

This is how a character sheet looks if you hide everything possible:
image

This is how an adversary sheet looks if you hide everything possible:
image

Maximum Info

It looks the same as it currently does

Checklist:

  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce any new warnings or errors.
  • My PR does not contain any copyrighted works that I do not have permission to use.
  • No part of this PR was created using generative AI tools.
  • I have tested my changes on Foundry VTT version: 13.351.

Additional context
Currently waiting for release 3.2.0 branch

Khunkurisu and others added 30 commits September 9, 2026 08:57
Since I went a different direction by letting resourceConfig hold the values for default and valid modes, this can be cleaned up and made nicer.
Since derived-value-field no longer defines what is valid/default for resource fields, we can add range to derived.modes.
This works as both a default and a validator. Given we assume derived is always the default mode if derived is available, Which I believe we dont intend to change.

If we do want to make it truly set the default, we can simply add a "none" to the resource Derived.Mode which will then be the new "default" value and then promptly be overrid by the sanitize method.
* feat: add scalar table for knucklebones

* feat: add knucklebones embedded action
* Added simple updateResourceMax function to actor sheet testing helper

* Removed dead playwright config file

* Started adding Adversary resource configuration test

* Patched updateResourceMax to filter to the correct per-resource window

* Added more resource config tests, including configuring health ranges
* fix(handlebars): use non-deprecated loadTemplates() location

Signed-off-by: Khunkurisu <creative.3d@live.com>

* fix(chat message): use renderHTML method instead of getHTML

Signed-off-by: Khunkurisu <creative.3d@live.com>

* fix(handlebars): use non-deprecated renderTemplate() location

Signed-off-by: Khunkurisu <creative.3d@live.com>

* fix(text editor): use .implementation and non-deprecated location

Signed-off-by: Khunkurisu <creative.3d@live.com>

* fix(file picker): use .implementation and non-deprecated location

Signed-off-by: Khunkurisu <creative.3d@live.com>

* fix(compendium collection): use non-deprecated location

Signed-off-by: Khunkurisu <creative.3d@live.com>

* fix(talent trees): use non-deprecated loadTexture() location

* fix(drag-drop): use .implementation and non-deprecated location

---------

Signed-off-by: Khunkurisu <creative.3d@live.com>
* chore: actually give useful non-copy-pasted comment to getRegisteredRollData method

* feat: refactor config data to be a method which takes in the actor document and returns a value
also hide placeholders if you can't edit sheet
@Khunkurisu Khunkurisu changed the title Limited Ownership limits information and is customizable feat(actor sheets): handle limited ownership visibility Oct 19, 2026
…ne another (#982)

* Made all prerequisite option data structures except level able to hold multiple ORed options

* First-pass of new prereq approach migration

* Started adding UI for prerequisites

* Fixed talent-tree-node-collection fields

* Fixed 3.1-3.2 migration

* Fixed item references in prerequisite-item-list.ts

* Fixed node tooltips for new structure

* Made edit prerequisite rule dialog respect all item-dropping prerequisites

* Return "undefined" for item lists on null/undefined prereqs

* Add UI for multi-item skill/attribute requirements on editing prerequisites

* Removed dead node-prerequisite-goal/talent-list files
@Khunkurisu
Khunkurisu changed the base branch from main to release-3.2.0 October 19, 2026 20:38
@Khunkurisu
Khunkurisu marked this pull request as ready for review October 19, 2026 20:43
@Khunkurisu
Khunkurisu requested a review from a team October 19, 2026 20:52

@Khunkurisu Khunkurisu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I maybe went a bit overboard here. Even if you disregard the actual suggested changes, the bare minimum is breaking up your defaults into a base, character, and adversary object each and recombining them as needed. There is absolutely no reason to repeat the shared keys for both, that is just begging for someone to change only one when making an update and we really don't need more of those problems.

Comment thread src/lang/en.json Resolved
Comment thread src/system/settings.ts Resolved
Comment thread src/system/settings.ts Resolved
Comment thread src/system/settings.ts Resolved
dtfe and others added 4 commits October 20, 2026 21:31
This has some problems like being unable to decide the order of the settings completely.
The current refactor did remove the functionality to choose the order of how the settings will appear. This fixes that.
@dtfe
dtfe requested a review from Khunkurisu October 20, 2026 20:51
@Khunkurisu
Khunkurisu force-pushed the release-3.2.0 branch 2 times, most recently from ebf669b to 2bb00b0 Compare October 22, 2026 22:50
@Khunkurisu
Khunkurisu requested review from a team as code owners November 2, 2026 20:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sheets do not properly respect access/ownership

3 participants