Add site forms UI: layout editor, approval queue, variant-aware capture#91
Merged
Conversation
SiteFormsPage lets a site coordinator start a layout as a copy of the sponsor's standard forms and adapt it — reorder items, rename forms, relabel questions in clinic wording — with a live data-equivalence panel driven by the server validator; drafts save as append-only versions and submit for approval only when equivalent. Once approved, a capture launcher opens variant form instances for the site's subjects. ApprovalQueuePage gives the sponsor the submitted layouts with an equivalence badge and per-event item summaries, plus approve/request-changes decisions with notes. FormEntryPage renders V.* instances through resolveVariantForm and keys every write on the item's canonical build group, so captured values are byte-identical in shape to standard-form sites (verified in the dev stack: variant capture for DEMO-002 landed under FO.VITAL_SIGNS canonical OIDs while pinned to the approved variant). The subject matrix response now carries siteId per subject for the launcher. Verified end-to-end across roles: coordinator seeds, reorders, saves, and submits; data manager approves with a note; coordinator captures through the site layout; values verified canonical in item_value_versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position: 7/8 (BYOFW half B).
resolveVariantFormand keys every write on the item's canonical build group, so captured values are byte-identical in shape to standard-form sites. The subject matrix response now carries siteId per subject for the launcher; the matrix itself deliberately stays on the standard layout as the oversight view.Verified end-to-end across roles on the dev stack: coordinator seeds, reorders, saves, and submits; data manager approves with a note; coordinator captures through the site layout; values verified canonical in item_value_versions.