Skip to content

feat: add e2e coverage and delivery docs#2

Merged
teuzowebdeveloper9 merged 1 commit into
mainfrom
feat/e2e-docs-delivery
May 21, 2026
Merged

feat: add e2e coverage and delivery docs#2
teuzowebdeveloper9 merged 1 commit into
mainfrom
feat/e2e-docs-delivery

Conversation

@teuzowebdeveloper9
Copy link
Copy Markdown
Owner

Contexto

Este PR adiciona uma camada final de qualidade para a entrega do desafio FURY Click Hero, sem mudar o escopo funcional da API. O objetivo e facilitar a avaliacao e demonstrar maturidade em teste, documentacao e operacao.

O que mudou

  • Adiciona testes e2e HTTP para webhook valido, payload invalido com Zod, idempotencia por adId + tenantId e consulta de status em GET /jobs/:id.
  • Melhora GET /health para validar processo da API, Redis PING e configuracao da URL externa usada pelo worker.
  • Adiciona docs/ARCHITECTURE.md com fluxo runtime, camadas, idempotencia, retry e endpoints operacionais.
  • Adiciona docs/TRADEOFFS.md explicando Render + Upstash, API/worker no mesmo processo e como evoluir em producao.
  • Adiciona docs/requests.http para testar o deploy publico rapidamente.
  • Atualiza README com badges, links de documentacao e destaque para os testes e2e.

Por que isso importa

Essas mudancas deixam a entrega mais facil de revisar e reduzem ambiguidade para o avaliador. O projeto passa a mostrar nao so que o fluxo funciona, mas tambem que as decisoes tecnicas foram pensadas com limites claros para um teste tecnico e com um caminho realista de evolucao para producao.

Validacao

  • npm run typecheck
  • npm run lint
  • npm test -- --runInBand
  • npm run build

Copy link
Copy Markdown
Owner Author

@teuzowebdeveloper9 teuzowebdeveloper9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review completed. No blocking findings.

Reviewed the PR with focus on runtime behavior, queue/idempotency guarantees, health check behavior, e2e coverage, and documentation quality. The changes are scoped, CI passed, and the new tests cover the main challenge flows.

Non-blocking note: GET /health currently reports degraded in the body while still returning HTTP 200 when Redis/config checks fail. That is acceptable for this technical challenge, but in production I would decide explicitly between liveness-style 200 and readiness-style 503 depending on how Render or another platform consumes the endpoint.

@teuzowebdeveloper9
Copy link
Copy Markdown
Owner Author

Code review attribution: the review above was performed by Codex (OpenAI) as an AI-assisted code review.

Scope reviewed by Codex: runtime behavior, BullMQ/Redis wiring, idempotency, e2e coverage, health check behavior, documentation, and CI validation. No blocking findings were found.

@teuzowebdeveloper9 teuzowebdeveloper9 merged commit 41db570 into main May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant