feat: add Scalar API documentation#1
Merged
Conversation
Owner
Author
There was a problem hiding this comment.
AI-assisted code review (Codex)
Findings
No blocking issues found in this PR.
What I reviewed
- Scalar integration through
@scalar/nestjs-api-reference. - OpenAPI document generation through
@nestjs/swagger. - Public routes exposed by this branch:
/docs,/openapi.json,/, and/health. - Documentation DTOs for webhook payloads, enqueue responses, job status, validation errors, and not found responses.
- README updates explaining the Scalar documentation and why it was added.
- Security impact of the adjusted Helmet CSP.
Validation performed
npm run typechecknpm run lintnpm test -- --runInBandnpm run build- Local smoke checks:
GET /docs -> 200GET /openapi.json -> 200GET / -> 200
Notes
- The Scalar addition is scoped to documentation and does not change the webhook, BullMQ, Redis, worker, retry, or idempotency flow.
- The global CSP now allows inline scripts/styles and jsDelivr so Scalar can render. This is acceptable for this no-auth technical challenge, but in a production app I would consider isolating docs behind a stricter route-specific policy or internal access control.
- The PR improves evaluator experience: reviewers can inspect request/response contracts and manually test endpoints without reading the implementation first.
Verdict
Looks good to merge after CI passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
Este PR adiciona documentacao interativa com Scalar para facilitar a avaliacao e o uso da mini-API do desafio FURY Click Hero.
Por que Scalar
O que mudou
Como validar
Resultado esperado
Trade-off
A documentacao foi adicionada sem criar front-end ou alterar o fluxo funcional do desafio. O objetivo e melhorar descobribilidade, testabilidade manual e clareza do contrato sem aumentar desnecessariamente o escopo.