Skip to content

Fix based on the latest laravel 9.x 's commit.#12

Open
daikisuyama wants to merge 4 commits into
tenantcloud:masterfrom
daikisuyama:patch-1
Open

Fix based on the latest laravel 9.x 's commit.#12
daikisuyama wants to merge 4 commits into
tenantcloud:masterfrom
daikisuyama:patch-1

Conversation

@daikisuyama

Copy link
Copy Markdown

Description

  1. Fix based on the latest laravel 9.x 's commit.
  2. Fix PHPDoc

Motivation and context

Laravel 9 has been released in 2022, so this library should update too.

How has this been tested?

I'm using your package in my project and it worked.
Please check below link

https://github.com/laravel/framework/blob/9.x/src/Illuminate/Database/Eloquent/SoftDeletes.php

Screenshots (if appropriate)

Nothing

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Comment thread src/SoftDeletesBoolean.php Outdated
Co-authored-by: YaroslavNahirnyi <40363149+YaroslavNahirnyi@users.noreply.github.com>
@ben221199

Copy link
Copy Markdown
Contributor

@YaroslavNahirnyi Seems that this PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants