Skip to content

feat - prepend basePath is domain manager plugin is being used #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sromicevelyn merged 2 commits into from
Jul 4, 2025
Merged

feat - prepend basePath is domain manager plugin is being used #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70dc5e1
feat - prepend basePath is domain manager plugin is being used
sromicevelyn Jul 4, 2025
1d3c581
fix - fixed plugins selection
sromicevelyn Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/definitionGenerator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,13 @@ class DefinitionGenerator {
slashPath = `/${(event?.http?.path || event.httpApi?.path) ?? ""}`;
}

const basePath = this.getBasePath();

if (basePath) {
// append the base path so server is just the pure domain
slashPath = `/${basePath}${slashPath}`;
}

if (paths[slashPath]) {
Object.assign(paths[slashPath], path);
} else {
Expand All @@ -280,6 +287,22 @@ class DefinitionGenerator {
}
}

/**
* @description Retrieves the basePath value if the domain manager plugin is used, allowing the server URL to be just the plain domain. The `basePath` will be prepended to each Lambda HTTP path.
* @returns {string}
*/
getBasePath() {
const plugins = this.serverless.service.plugins || [];

let basePath = "";

if (plugins.includes("serverless-domain-manager")) {
basePath = this.serverless.service.custom.basePath || "";
}

return basePath;
}

createServers(servers) {
const serverDoc = servers;
const newServers = [];
Expand Down