PS-7004 : LAP - State Lead list = the Status filter does not render t…#3184
PS-7004 : LAP - State Lead list = the Status filter does not render t…#3184Tejashrimajage wants to merge 1 commit into
Conversation
…he expected record as per selected value
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the status search filter to tenantStatus in the State Lead search form and introduces an 'All' option. In the state lead page, it deletes the legacy status field and removes tenantStatus if its value is 'all'. The reviewer suggests migrating legacy status values from localStorage to tenantStatus before deletion to prevent users from losing their saved filters.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| delete formData.status; | ||
| if (formData.tenantStatus === 'all') { | ||
| delete formData.tenantStatus; | ||
| } |
There was a problem hiding this comment.
When renaming the search filter from status to tenantStatus, any previously saved search filters in the user's localStorage (under the 'stateLead' key) will still contain the legacy status field. Simply deleting formData.status without migrating it means users will lose their saved status filter on page load.
Consider mapping the legacy status value to tenantStatus if tenantStatus is not already present, before deleting the legacy key.
if (formData.status && !formData.tenantStatus) {
formData.tenantStatus = formData.status;
}
delete formData.status;
if (formData.tenantStatus === 'all') {
delete formData.tenantStatus;
}
|
1 participant
…he expected record as per selected value
https://prathamdigitalteam.atlassian.net/browse/PS-7004