Skip to content

PS-6934 : Enable 'Open in New Tab' option in LMP, LAP and PLP#3079

Open
Tejashrimajage wants to merge 12 commits into
tekdi:feat-open-in-new-tabfrom
Tejashrimajage:release-1.16.0-prod-fix
Open

PS-6934 : Enable 'Open in New Tab' option in LMP, LAP and PLP#3079
Tejashrimajage wants to merge 12 commits into
tekdi:feat-open-in-new-tabfrom
Tejashrimajage:release-1.16.0-prod-fix

Conversation

@Tejashrimajage

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Sidebar component in the admin application to use native anchor tags for navigation instead of relying solely on JavaScript-based click handlers. Specifically, ListItemButton elements are updated with component and href attributes to improve accessibility and standard link behavior, while retaining the drawer-close behavior on click. No review comments were provided, so there is no additional feedback to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

console.log('[player:close]', detail);
// Notify parent learner page so it can redirect via activeLink (sbplayer runs in iframe).
if (window.parent !== window) {
window.parent.postMessage({ type: 'player:close' }, '*');
@Tejashrimajage Tejashrimajage marked this pull request as draft June 5, 2026 09:33
@Tejashrimajage Tejashrimajage marked this pull request as ready for review June 5, 2026 12:21
@Tejashrimajage Tejashrimajage marked this pull request as draft June 8, 2026 06:49
@Tejashrimajage Tejashrimajage changed the base branch from release-1.16.0-prod-fix to feat-open-in-new-tab June 15, 2026 13:07
@Tejashrimajage Tejashrimajage changed the title LAP - Menus open in new tab changes PS-6934 : Enable 'Open in New Tab' option in LMP, LAP and PLP Jun 15, 2026
@Tejashrimajage Tejashrimajage marked this pull request as ready for review June 15, 2026 13:10
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
15.4% Duplication on New Code (required ≤ 3%)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants