-
Notifications
You must be signed in to change notification settings - Fork 18
Fix font loading normalization and improve font screen UX #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0262d67
drawer: add proxy toggle item between Saved Messages and Settings
relativemodder a4f0ef1
refactor: fix CR warnings
relativemodder a6a1916
Fix MD3 sections style not applying in Proxy Settings list
relativemodder 58693ee
meow: Fix font loading normalization and improve font screen UX
relativemodder 79f4fe5
Fix CR warnings
relativemodder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
| From: Andrew <kezin636@gmail.com> | ||
| Date: Thu, 16 Jul 2026 12:32:04 +0300 | ||
| Subject: Fix MD3 sections style not applying in Proxy Settings list | ||
|
|
||
| --- | ||
| .../src/main/java/org/telegram/ui/ProxyListActivity.java | 5 ----- | ||
| 1 file changed, 5 deletions(-) | ||
|
|
||
| diff --git a/TMessagesProj/src/main/java/org/telegram/ui/ProxyListActivity.java b/TMessagesProj/src/main/java/org/telegram/ui/ProxyListActivity.java | ||
| index 0000000..0000000 100644 | ||
| --- a/TMessagesProj/src/main/java/org/telegram/ui/ProxyListActivity.java | ||
| +++ b/TMessagesProj/src/main/java/org/telegram/ui/ProxyListActivity.java | ||
| @@ -1008,27 +1008,22 @@ public class ProxyListActivity extends BaseFragment implements NotificationCente | ||
| break; | ||
| case VIEW_TYPE_TEXT_SETTING: | ||
| view = new TextSettingsCell(mContext); | ||
| - view.setBackgroundColor(Theme.getColor(Theme.key_windowBackgroundWhite)); | ||
| break; | ||
| case VIEW_TYPE_HEADER: | ||
| view = new HeaderCell(mContext); | ||
| - view.setBackgroundColor(Theme.getColor(Theme.key_windowBackgroundWhite)); | ||
| break; | ||
| case VIEW_TYPE_TEXT_CHECK: | ||
| view = new TextCheckCell(mContext); | ||
| - view.setBackgroundColor(Theme.getColor(Theme.key_windowBackgroundWhite)); | ||
| break; | ||
| case VIEW_TYPE_INFO: | ||
| view = new TextInfoPrivacyCell(mContext); | ||
| break; | ||
| case VIEW_TYPE_SLIDE_CHOOSER: | ||
| view = new SlideChooseView(mContext); | ||
| - view.setBackgroundColor(Theme.getColor(Theme.key_windowBackgroundWhite)); | ||
| break; | ||
| case VIEW_TYPE_PROXY_DETAIL: | ||
| default: | ||
| view = new TextDetailProxyCell(mContext); | ||
| - view.setBackgroundColor(Theme.getColor(Theme.key_windowBackgroundWhite)); | ||
| break; | ||
| } | ||
| view.setLayoutParams(new RecyclerView.LayoutParams(RecyclerView.LayoutParams.MATCH_PARENT, RecyclerView.LayoutParams.WRAP_CONTENT)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Either normalize TTC faces or narrow the feature scope.
The implementation explicitly skips TTC containers while the feature documentation covers imported fonts generally.
src/kotlin/helpers/font/FontLibrary.kt#L367-L369: traverse each TTC font directory and update affected table checksums, or explicitly reject/exclude TTC normalization.FEATURES.md#L221-L221: limit the claim to standalone TTF/OTF files until TTC support exists.📍 Affects 2 files
src/kotlin/helpers/font/FontLibrary.kt#L367-L369(this comment)FEATURES.md#L221-L221🤖 Prompt for AI Agents
Source: Coding guidelines