Skip to content

chore: address feedback around admin reindex endpoints#657

Draft
gpaoloni wants to merge 63 commits intomasterfrom
gian_CHI-2759-II
Draft

chore: address feedback around admin reindex endpoints#657
gpaoloni wants to merge 63 commits intomasterfrom
gian_CHI-2759-II

Conversation

@gpaoloni
Copy link
Collaborator

@gpaoloni gpaoloni commented Jun 7, 2024

Description

This PR is a followup to the chain #651 -> #652 -> #648.

I'm addressing (most of) the feedback left in those PRs here, cause this is easier than addressing (more) merge conflicts 😝

In this PR:

  • Moved the autoPaginate and related utilities to a new module, @tech-matters/batch-processing that you can find under /packages//batch-processing, as suggested.
  • Addressed concerns around lacking "reindex multiple account". To do so admin-cli:reindex:hrm now supports - TODO -

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags / configuration added

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

mythilytm and others added 21 commits May 30, 2024 14:16
* feat: build script for reindexing contacts and cases

* change options for indexing

* sqs debug

* revert logs

* modify to have more graceful error handling for user

* modify to have more graceful error handling for user

* modify to have more graceful error handling for user

---------

Co-authored-by: Gianfranco Paoloni <paolonigianfranco@gmail.com>
@gpaoloni gpaoloni changed the base branch from master to gian_CHI-2759 June 7, 2024 20:18
Base automatically changed from gian_CHI-2759 to CHI-2702-reindex-contacts June 10, 2024 18:43
Base automatically changed from CHI-2702-reindex-contacts to master June 10, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants